OCPBUGS-13547: remove special cases for featureset in rendering#7189
OCPBUGS-13547: remove special cases for featureset in rendering#7189openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
|
@deads2k: This pull request references Jira Issue OCPBUGS-13547, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| ADDITIONAL_FLAGS+=("--cloud-provider-config-input-file=/assets/manifests/cloud-provider-config.yaml") | ||
| fi | ||
| {{- if .FeatureSet }} | ||
| ADDITIONAL_FLAGS+=("--feature-set={{.FeatureSet}}") |
There was a problem hiding this comment.
this fixes the current techpreview failure
|
/lgtm |
|
this was approved once before. approving now to unstick out techpreview. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/override ci/prow/e2e-aws-ovn https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_installer/7189/pull-ci-openshift-installer-master-e2e-aws-ovn/1658459336445267968 failed only on disruption |
|
@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-aws-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@deads2k: Jira Issue OCPBUGS-13547: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-13547 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
reintroduce #7158 since openshift/cluster-config-operator#305 merged