Switch to openshift/osincli

[skitt]

This is identical to RangelReale/osincli; the latter has been archived.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skitt
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bertinatto]

Since our fork doesn’t include any changes from the original package, and go mod already pins the original revision from ~10 years ago, I’m wondering if there are any tangible benefits to making this change.

Is there something I might be overlooking?

Would migrating the code to https://pkg.go.dev/golang.org/x/oauth2 be a more effective approach instead?

[skitt]

Since our fork doesn’t include any changes from the original package, and go mod already pins the original revision from ~10 years ago, I’m wondering if there are any tangible benefits to making this change.

Is there something I might be overlooking?

I think it’s beneficial to clarify the dependencies — in future, if a change needs to be made in osincli, it’s more obvious that it’s something we have direct influence over if it’s in the openshift org (which seems to have been the initial intention anyway).

Would migrating the code to https://pkg.go.dev/golang.org/x/oauth2 be a more effective approach instead?

Probably, yes, but it’s a bit more effort ;-).

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[skitt]

/remove-lifecycle stale

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[skitt]

/remove-lifecycle stale

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[skitt]

/remove-lifecycle stale

[openshift-ci]

@skitt: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.