manifestclient: reject WatchList

[p0lyn0mial]

Reject sendInitialEvents=true (WatchList) for manifest client with a clear error. Returning an error forces clients to fallback to a standard LIST request.

Rationale: we read from disk, WatchList is unnecessary, and forcing an error keeps a single "list" path.

This PR will unblock #2055

[openshift-ci]

@p0lyn0mial: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[rh-roman]

/lgtm
/hold

[p0lyn0mial]

@jacobsee feel free to cancel the hold once you are ok with this pr/approach.

[jacobsee]

/lgtm
/unhold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobsee, p0lyn0mial, rh-roman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [p0lyn0mial]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment