Draft
Conversation
Call the tool coroutine directly instead of ainvoke() to preserve the (content, artifact) tuple that langchain-mcp-adapters returns. Extract structured_content from the artifact dict and propagate it through execute_tool_call (now a 4-tuple) and _execute_single_tool_call via ToolMessage additional_kwargs. Co-authored-by: Cursor <cursoragent@cursor.com>
Introduce ols.src.mcp.tool_registry that discovers and caches UI metadata (_meta.ui.resourceUri, _meta.ui.visibility) from configured MCP servers. The registry maps tool names to ToolUIMetadata and resource URIs to config server names, enabling: - is_model_visible(): filter app-only tools from LLM binding - get_tool_ui_metadata(): look up UI resource URIs for tool results - get_config_name_for_resource_uri(): route ui:// URIs to servers Co-authored-by: Cursor <cursoragent@cursor.com>
Add a FastAPI lifespan handler that calls discover_tool_ui_metadata() during application startup. This populates the tool registry with UI metadata from all configured MCP servers so that tool results can be routed to interactive UIs later. Co-authored-by: Cursor <cursoragent@cursor.com>
Use is_model_visible() to exclude app-only tools (visibility: ["app"]) from LLM tool binding. For tools with a UI resource, send a short placeholder message to the LLM instead of the full tool output to conserve tokens -- the console renders the full data via the interactive UI. Also forward structured_content from tool artifacts in streamed tool_result chunks, handle missing 'properties' key in tool schemas safely, and include tool_name + server_name in result metadata. Co-authored-by: Cursor <cursoragent@cursor.com>
Introduce two new endpoints under /v1/mcp-apps that enable the console to render interactive UIs from MCP servers: - POST /v1/mcp-apps/resources: fetch ui:// resources (HTML/JS/CSS) from MCP servers using the tool registry to resolve URIs to servers - POST /v1/mcp-apps/tools/call: call MCP tools directly and return content + structuredContent for the interactive UI Add corresponding Pydantic request/response models and register the new router. Depends-On: mcp-app-tool-registry Co-authored-by: Cursor <cursoragent@cursor.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@onmete: This pull request references OLS-2568 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@onmete: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
POST /v1/mcp-apps/resourcesto fetchui://resources (HTML/JS/CSS) from MCP serversPOST /v1/mcp-apps/tools/callto call MCP tools directly and return content + structuredContentDependencies
Depends on #2747
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing