STOR-2865: API: introduce LocalVolumeDeviceLink CRD and related fields#580
STOR-2865: API: introduce LocalVolumeDeviceLink CRD and related fields#580dobsonj wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
@dobsonj: This pull request references STOR-2865 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dobsonj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@dobsonj: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| // DefaultDeviceLinkPolicy defines the default device link policy for this object. | ||
| // +optional | ||
| DefaultDeviceLinkPolicy LocalVolumeDeviceLinkPolicy `json:"defaultDeviceLinkPolicy,omitempty"` | ||
| } |
There was a problem hiding this comment.
I thought we wanted this for LocalVolume objects as well?
There was a problem hiding this comment.
Also, are we going to retroactively reconcile this after this is changed for LocalVolumeSet or LocalVolume objects after initial creation?
3 participants
https://issues.redhat.com/browse/STOR-2865
Enhancement: https://github.com/openshift/enhancements/blob/master/enhancements/storage/lso-recreate-symlinks.md
This PR introduces the LocalVolumeDeviceLink CRD to establish a link between the device on the nodes and the PersistentVolume created by LSO.
/cc @openshift/storage