SPLAT-2612: Changed AWS dedicated host webhook to allow host info with other tenancies

[vr4manta]

SPLAT-2612

Changes

• Changed AWS dedicated host webhook to allow host info with other tenancies

Notes

This change is being done due to difference in behavior with CAPA vs MAPI. CAPA seems to allow host affinity and ID even when tenancy is default or dedicated. We found this behavior during our CCAPIO testing: openshift/cluster-capi-operator#374

Documentation on tenancy behavior/usage:

• https://docs.aws.amazon.com/license-manager/latest/userguide/conversion-tenancy.html

[openshift-ci-robot]

@vr4manta: This pull request references SPLAT-2612 which is a valid jira issue.

Details

In response to this:

SPLAT-2612

Changes

• Changed AWS dedicated host webhook to allow host info with other tenancies

Notes

This change is being done due to difference in behavior with CAPA vs MAPI. CAPA sees to allow host affinity and ID even when tenancy is default or dedicated. We found this behavior during our CCAPIO testing: openshift/cluster-capi-operator#374

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chrischdi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@vr4manta: This pull request references SPLAT-2612 which is a valid jira issue.

Details

In response to this:

SPLAT-2612

Changes

• Changed AWS dedicated host webhook to allow host info with other tenancies

Notes

This change is being done due to difference in behavior with CAPA vs MAPI. CAPA seems to allow host affinity and ID even when tenancy is default or dedicated. We found this behavior during our CCAPIO testing: openshift/cluster-capi-operator#374

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@vr4manta: This pull request references SPLAT-2612 which is a valid jira issue.

Details

In response to this:

SPLAT-2612

Changes

• Changed AWS dedicated host webhook to allow host info with other tenancies

Notes

This change is being done due to difference in behavior with CAPA vs MAPI. CAPA seems to allow host affinity and ID even when tenancy is default or dedicated. We found this behavior during our CCAPIO testing: openshift/cluster-capi-operator#374

Documentation on tenancy behavior/usage:

• https://docs.aws.amazon.com/license-manager/latest/userguide/conversion-tenancy.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vr4manta]

/assign @damdo

[openshift-ci]

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[vr4manta]

/close
closing this for now as we are just going to block other PRs until upstream fixes are made and ported downstream.

[openshift-ci]

@vr4manta: Closed this PR.

Details

In response to this:

/close
closing this for now as we are just going to block other PRs until upstream fixes are made and ported downstream.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.