mockgen deprecated: use uber-go/mock instead#131
mockgen deprecated: use uber-go/mock instead#131sebrandon1 wants to merge 1 commit intoopenshift:mainfrom
Conversation
Karthik-K-N
left a comment
There was a problem hiding this comment.
Thank you for the PR
Test failure is unrelated to this Platform
/lgtm
/approve
|
/test okd-scos-e2e-aws-ovn |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Karthik-K-N, sebrandon1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override okd-scos-e2e-aws-ovn |
|
@Karthik-K-N: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Since the failure is not related to the platform PowerVS /override ci/prow/okd-scos-e2e-aws-ovn |
|
@Karthik-K-N: Overrode contexts on behalf of Karthik-K-N: ci/prow/okd-scos-e2e-aws-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6251f1c to
236f8a5
Compare
|
New changes are detected. LGTM label has been removed. |
|
@sebrandon1: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
https://github.com/golang/mock is marked as archived as of
June 27, 2023. They recommend using go.uber.org/mock.This PR attempts to change the dependency to one that is maintained.
Tracking issue: redhat-best-practices-for-k8s/telco-bot#45