Add a linter check for environment selectors.#2619
Add a linter check for environment selectors.#2619bergmannf wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bergmannf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
bergmannf
force-pushed
the
add-linter-clusterselection
branch
2 times, most recently
from
b87e6c0 to
7abefbd
Compare
|
/retest |
| operator: In | ||
| values: | ||
| - "staging" | ||
| - "stage" |
There was a problem hiding this comment.
I doubt this is the case, but would be good to check with fedramp folks to make sure they aren't using stage
There was a problem hiding this comment.
Checked with Fedramp and they indeed need to have stage as well - so I added it to the linter.
This should prevent putting an invalid environment selector like 'stage' or 'int' into this repo. A workaround exists for syncsets for FedRAMP as those allow 'stage' until https://issues.redhat.com/browse/HCMSEC-2597 is implemented. Also updated to ubi9 & python3.12 to allow match expressions.
bergmannf
force-pushed
the
add-linter-clusterselection
branch
from
37d0b45 to
cb0ad92
Compare
|
@bergmannf: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
This should prevent putting an invalid environment selector like 'stg' or 'int' into this repo.
What type of PR is this?
feature
What this PR does / why we need it?
Additional checks when using environment selectors.
Which Jira/Github issue(s) this PR fixes?
Special notes for your reviewer:
Pre-checks (if applicable):
Tested latest changes against a cluster
Included documentation changes with PR
If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with: