SREP-3410: Add ec2:DescribeInstanceTypes to CAPA policy#2642
SREP-3410: Add ec2:DescribeInstanceTypes to CAPA policy#2642MitaliBhalla wants to merge 1 commit intoopenshift:masterfrom
Conversation
…-to-zero Add ec2:DescribeInstanceTypes permission to the ReadPermissions Sid in the CAPA controller manager credentials policy. This permission is required for scale-to-zero functionality to populate AWSMachineTemplate.Status.Capacity fields. Fixes SREP-3410
|
@MitaliBhalla: This pull request references SREP-3410 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@MitaliBhalla: This pull request references SREP-3410 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MitaliBhalla The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@MitaliBhalla: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold |
What type of PR is this?
feature
What this PR does / why we need it?
ROSA HCP supports scale-to-zero functionality. For this to work,
AWSMachineTemplate.Status.Capacityfields need to be populated by the CAPA provider.This PR adds
ec2:DescribeInstanceTypespermission to the CAPA controller manager credentials policy (ROSANodePoolManagementPolicy), enabling the controller to query instance type specifications (vCPU, memory, etc.) needed for capacity calculations.Permission Details:
ec2:DescribeInstanceTypesAWSMachineTemplate.Status.Capacityfor scale-to-zero*(required for Describe actions)Which Jira/Github issue(s) this PR fixes?
Fixes SREP-3410
Special notes for your reviewer:
This permission already exists in other policies in this repo:
sts_hcp_installer_permission_policy.jsonsts_extended_hcp_support_permission_policy.json(NetworkVerifier)openshift_hcp_cloud_network_config_cloud_credentials_permission_policy.jsonPre-checks (if applicable):