Skip to content

Conversation

@weshayutin
Copy link
Contributor

Why the changes were made

make deploy-olm was failing w/

INFO[0012] Creating a File-Based Catalog of the bundle "ttl.sh/oadp-operator-bundle-f509f50a:1h" 
INFO[0014] Generated a valid File-Based Catalog         
FATA[0015] Failed to run bundle: create catalog: error creating registry pod: error creating pod: pods "ttl-sh-oadp-operator-bundle-f509f50a-1h" is forbidden: violates PodSecurity "restricted:latest": allowPrivilegeEscalation != false (container "registry-grpc-init" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "registry-grpc-init" must set securityContext.capabilities.drop=["ALL"]) 
make: *** [Makefile:545: deploy-olm] Error 1

How to test the changes made

On a OCP 4.21 cluster I was unable to deploy the dev build

@openshift-ci
Copy link

openshift-ci bot commented Jan 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weshayutin
Once this PR has been reviewed and has the lgtm label, please assign sseago for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 15, 2026

Walkthrough

Updated Makefile: bumped OPERATOR_SDK_VERSION from v1.35.0 to v1.42.0, added a namespace label step (uses OC_CLI and tolerates failure) in deploy-olm, and added a --timeout 5m flag to the operator-sdk run bundle invocation.

Changes

Cohort / File(s) Summary
Makefile (version & deploy-olm)
Makefile
- OPERATOR_SDK_VERSION updated from v1.35.0 to v1.42.0.
- In deploy-olm target: added namespace labeling command (uses OC_CLI, allowed to fail) to set pod-security constraints; added --timeout 5m to operator-sdk run bundle.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes



📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 57200b6 and 8d47c62.

📒 Files selected for processing (1)
  • Makefile
🚧 Files skipped from review as they are similar to previous changes (1)
  • Makefile

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@weshayutin
Copy link
Contributor Author

@kaovilai do you know what's going on?

@kaovilai
Copy link
Member

Submitted PR to operator-framework/operator-sdk#7040

@weshayutin
Copy link
Contributor Author

/recheck

@weshayutin
Copy link
Contributor Author

/retest all

@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

@weshayutin: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test 4.21-ci-index
/test 4.21-e2e-test-aws
/test 4.21-e2e-test-hcp-aws
/test 4.21-e2e-test-kubevirt-aws
/test 4.21-images
/test images
/test unit-test

The following commands are available to trigger optional jobs:

/test 4.21-e2e-test-cli-aws

Use /test all to run all jobs.

Details

In response to this:

/retest all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@weshayutin
Copy link
Contributor Author

/test all

@shubham-pampattiwar
Copy link
Member

CI failing - need to run make bundle after the operator-sdk bump.

btw the namespace label fix alone would work without needing the version bump or bundle regen.

@kaovilai
Copy link
Member

@kaovilai
Copy link
Member

but yes lets not update sdk version atm.. no benefit

@kaovilai
Copy link
Member

/hold

prefer: #2078

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 29, 2026

@weshayutin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-test 8d47c62 link true /test unit-test
ci/prow/4.21-e2e-test-cli-aws 8d47c62 link false /test 4.21-e2e-test-cli-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants