Migrate away from deprecated ioutil#202
Open
sebrandon1 wants to merge 1 commit intoopenshift:masterfrom
Open
Conversation
Contributor
|
/approve |
openshift-ci
bot
added
the
approved
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ibihim, liouk, sebrandon1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
added
the
needs-rebase
sebrandon1
force-pushed
the
ioutil_deprecation
branch
from
3229315 to
a309d38
Compare
Contributor
|
New changes are detected. LGTM label has been removed. |
openshift-merge-robot
removed
the
needs-rebase
Contributor
|
@sebrandon1: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ioutilhas been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutilTracking issue: redhat-best-practices-for-k8s/telco-bot#52
Core updates to file and stream reading:
ioutil.ReadAllwithio.ReadAllfor reading from streams and HTTP response bodies across authentication, OAuth, and server-related packages. [1] [2] [3] [4] [5] [6] [7]ioutil.ReadFilewithos.ReadFilefor reading files in configuration and OAuth server logic, such as loading secrets and certificates. [1] [2] [3] [4] [5]Test code modernization:
os.CreateTempinstead ofioutil.TempFileandos.WriteFileinstead ofioutil.WriteFilefor creating and writing temporary files. [1] [2] [3] [4] [5]io.ReadAllinstead ofioutil.ReadAllfor reading HTTP response bodies. [1] [2] [3] [4]General import cleanup:
ioutilimports and added necessaryosorioimports in affected files. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]These updates ensure the codebase is up-to-date with the latest Go standards and removes reliance on deprecated APIs.