WIP: OCPBUGS-63228: groupmapper: make direct API calls to retrieve groups instead of using a cache

[liouk]

Per the Synchronizing User Groups on Login enhancement, OIDC groups are synchronized to Openshift groups upon user login. During synchronization, the oauth-server checks current user groups and compares with the ones obtained from the provider via the token; it then calculates which groups need to be added/removed to/from the user, and performs the changes accordingly.

There is currently an issue with this implementation, as the server uses a groups cache to determine user group membership; this cache can be stale, which can lead to problems such as OCPBUGS-63228.

During authorization, correctness is non-negotiable, so we must never rely on a cache to determine user group membership. This PR removes the group cache and replaces it with direct API calls; correctness comes at the cost of increased performance, especially in large clusters with large numbers of groups.

[openshift-ci-robot]

@liouk: This pull request references Jira Issue OCPBUGS-63228, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Per the Synchronizing User Groups on Login enhancement, OIDC groups are synchronized to Openshift groups upon user login. During synchronization, the oauth-server checks current user groups and compares with the ones obtained from the provider via the token; it then calculates which groups need to be added/removed to/from the user, and performs the changes accordingly.

There is currently an issue with this implementation, as the server uses a groups cache to determine user group membership; this cache can be stale, which can lead to problems such as OCPBUGS-63228.

During authorization, correctness is non-negotiable, so we must never rely on a cache to determine user group membership. This PR removes the group cache and replaces it with direct API calls; correctness comes at the cost of increased performance, especially in large clusters with large numbers of groups.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liouk
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@liouk: This pull request references Jira Issue OCPBUGS-63228, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xingxingxia

Details

In response to this:

Per the Synchronizing User Groups on Login enhancement, OIDC groups are synchronized to Openshift groups upon user login. During synchronization, the oauth-server checks current user groups and compares with the ones obtained from the provider via the token; it then calculates which groups need to be added/removed to/from the user, and performs the changes accordingly.

There is currently an issue with this implementation, as the server uses a groups cache to determine user group membership; this cache can be stale, which can lead to problems such as OCPBUGS-63228.

During authorization, correctness is non-negotiable, so we must never rely on a cache to determine user group membership. This PR removes the group cache and replaces it with direct API calls; correctness comes at the cost of increased performance, especially in large clusters with large numbers of groups.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[liouk]

/retest-required

[openshift-ci]

@liouk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.