OCPBUGS-59070: CVE-2025-53547 openshift4/ose-operator-sdk-rhel8: Helm Chart Code Execution [openshift-4.15.z]

[PillaiManish]

Description of the change:

Based on the analysis from GHSA-557j-xg8c-q2mm, the vulnerability in operator-sdk is found in the code path leveraging the downloader.Manager.Build() method from Helm SDK. The fix for the CVE is adopted in the recent Helm SDK version 3.18.4. The same helm version is not adopted in the present release-4.15, hence, the PR adds update in the operator-sdk layer to mitigate the vulnerability.

Manual backport of PR: #434 for openshift-4.15.

[openshift-ci-robot]

@PillaiManish: This pull request references Jira Issue OCPBUGS-59070, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-59070 to depend on a bug targeting a version in 4.16.0, 4.16.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Description of the change:

Based on the analysis from GHSA-557j-xg8c-q2mm, the vulnerability in operator-sdk is found in the code path leveraging the downloader.Manager.Build() method from Helm SDK. The fix for the CVE is adopted in the recent Helm SDK version 3.18.4. The same helm version is not adopted in the present release-4.15, hence, the PR adds update in the operator-sdk layer to mitigate the vulnerability.

Manual backport of PR: #434 for openshift-4.15.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PillaiManish
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[PillaiManish]

/retest

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[PillaiManish]

/jira refresh

[openshift-ci-robot]

@PillaiManish: This pull request references Jira Issue OCPBUGS-59070, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.z) matches configured target version for branch (4.15.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-59086 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-59086 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
• bug has dependents

Requesting review from QA contact:
/cc @xiaojiey

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[chiragkyal]

@PillaiManish, I think there was some issue with the UTs. Did we modify the UTs to make the CI pass? If yes, what were the changes?

[PillaiManish]

@PillaiManish, I think there was some issue with the UTs. Did we modify the UTs to make the CI pass? If yes, what were the changes?

Yes, there was some nil pointer for the dependencies --> while i try to download the dependencies, so I just removed one of the test case, testing with normal chart.lock one.

[chiragkyal]

@PillaiManish, I think there was some issue with the UTs. Did we modify the UTs to make the CI pass? If yes, what were the changes?

Yes, there was some nil pointer for the dependencies --> while i try to download the dependencies, so I just removed one of the test case, testing with normal chart.lock one.

Why it's so for 4.15.z and we don't see this happening for later versions?

[PillaiManish]

Why it's so for 4.15.z and we don't see this happening for later versions?

In the newer code: https://github.com/openshift/ocp-release-operator-sdk/blob/main/vendor/helm.sh/helm/v3/pkg/getter/ocigetter.go#L52-L57
there is handling for registryClient

But in the older version: https://github.com/openshift/ocp-release-operator-sdk/blob/release-4.15/vendor/helm.sh/helm/v3/pkg/getter/ocigetter.go#L40-L43
there is no such handling. So, it throws a nil pointer error.

[mytreya-rh]

/lgtm
/label backport-risk-assessed

[PillaiManish]

Why it's so for 4.15.z and we don't see this happening for later versions?

In the newer code: https://github.com/openshift/ocp-release-operator-sdk/blob/main/vendor/helm.sh/helm/v3/pkg/getter/ocigetter.go#L52-L57 there is handling for registryClient

But in the older version: https://github.com/openshift/ocp-release-operator-sdk/blob/release-4.15/vendor/helm.sh/helm/v3/pkg/getter/ocigetter.go#L40-L43 there is no such handling. So, it throws a nil pointer error.

@chiragkyal FYI
helm/helm#9267
helm/helm#9409
https://github.com/helm/helm/blob/release-3.11/pkg/getter/ocigetter.go#L40

[chiragkyal]

Thanks @PillaiManish for the explanation about the issue.

/cc @mytreya-rh

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

@PillaiManish: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[chiragkyal]

/hold

[PillaiManish]

@cursor review

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale