WRKLDS-1599: Drop support for image manifest schema 1

[tchap]

The change itself is fairly small, but there were quite a few tests using schema1. These had to be updated. Some test cases also don't make sense any more as you cannot really update an image schema2, that would change the hash. So tests updating an image with a signature were removed as signatures are not supported in schema2 implicitly.

Feel free to propose more test cases if anything comes up your mind, I did what I could without learning all the intricacies of the codebase, which meant extending the tests for imageutil.InternalImageWithMetadata for all schema types, then aligning all other breaking tests.

The PR is a bit chaotic in the sense that there are multiple mock manifests and configs scattered across the codebase. I normalized what made sense to me, but some chaos is still there. Particularly there are separate tests for filling in the image object from the string manifest and config, then there are API tests for actually posting a manifest. These are entirely separate tests.

[openshift-ci-robot]

@tchap: This pull request references WRKLDS-1599 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This is needed so that we can upgrade to distribution/v3@v3.0.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tchap]

/retest

[openshift-ci-robot]

@tchap: This pull request references WRKLDS-1599 which is a valid jira issue.

Details

In response to this:

This is needed so that we can upgrade to distribution/v3@v3.0.0

The change itself is fairly small, but there were quite a few tests using schema1. These must have been updated. Some test cases also don't make sense any more as you cannot really update an image schema2, that would change the hash. So tests updating an image with a signature were removed as signatures are not supported in schema2 implicitly.

Feel free to propose more test cases if anything comes up your mind, I did what I could without learning all the intricacies of the codebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@tchap: This pull request references WRKLDS-1599 which is a valid jira issue.

Details

In response to this:

This is needed so that we can upgrade to distribution/v3@v3.0.0

The change itself is fairly small, but there were quite a few tests using schema1. These must have been updated. Some test cases also don't make sense any more as you cannot really update an image schema2, that would change the hash. So tests updating an image with a signature were removed as signatures are not supported in schema2 implicitly.

Feel free to propose more test cases if anything comes up your mind, I did what I could without learning all the intricacies of the codebase, which meant extending the tests for imageutil.InternalImageWithMetadata for all schema types, then aligning all other breaking tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@tchap: This pull request references WRKLDS-1599 which is a valid jira issue.

Details

In response to this:

The change itself is fairly small, but there were quite a few tests using schema1. These must have been updated. Some test cases also don't make sense any more as you cannot really update an image schema2, that would change the hash. So tests updating an image with a signature were removed as signatures are not supported in schema2 implicitly.

Feel free to propose more test cases if anything comes up your mind, I did what I could without learning all the intricacies of the codebase, which meant extending the tests for imageutil.InternalImageWithMetadata for all schema types, then aligning all other breaking tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tchap]

/unhold

[openshift-ci-robot]

@tchap: This pull request references WRKLDS-1599 which is a valid jira issue.

Details

In response to this:

The change itself is fairly small, but there were quite a few tests using schema1. These had to be updated. Some test cases also don't make sense any more as you cannot really update an image schema2, that would change the hash. So tests updating an image with a signature were removed as signatures are not supported in schema2 implicitly.

Feel free to propose more test cases if anything comes up your mind, I did what I could without learning all the intricacies of the codebase, which meant extending the tests for imageutil.InternalImageWithMetadata for all schema types, then aligning all other breaking tests.

The PR is a bit chaotic in the sense that there are multiple mock manifests and configs scattered across the codebase. I normalized what made sense to me, but some chaos is still there. Particularly there are separate tests for filling in the image object from the string manifest and config, then there are API tests for actually posting a manifest. These are entirely separate tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sanchezl]

These types are duplicated in openshift/library-go pkg/image/dockerv1client/types.go

[tchap]

These types are duplicated in openshift/library-go pkg/image/dockerv1client/types.go

I guess I can just migrate to library-go in a subsequent PR and remove the packages as present in this repo.

[tchap]

/retest

[tchap]

/retest

[openshift-ci]

@tchap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-cmd	99e8cd6	link	false	/test e2e-aws-ovn-cmd

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[sanchezl]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanchezl, tchap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/image/OWNERS [sanchezl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-openshift-apiserver
This PR has been included in build ose-openshift-apiserver-container-v4.20.0-202507071217.p0.g037953b.assembly.stream.el9.
All builds following this will include this PR.