Skip to content

OADP self-service uncomment topic map entries #93978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaelryanpeter merged 1 commit into from
Jun 9, 2025
Merged

OADP self-service uncomment topic map entries #93978

michaelryanpeter merged 1 commit into from
Jun 9, 2025

Conversation

@shdeshpa07
Copy link
Contributor

@shdeshpa07 shdeshpa07 commented May 30, 2025 •
edited
Loading

Jira

OADP Self-Service feature. This PR uncomments the _topic_map.yaml entries and addresses a few merge review comments.

The SMEs have already reviewed the original PR. And as such, this PR only focusses on uncommenting the topic map entries and a few merge review comments.

Version

  • OCP 4.19 only

Preview

QE Review

  • QE has approved this change.

@shdeshpa07
OADP self-service uncomment topic map entries
678ffc5 
Signed-off-by: Shruti Deshpande <shdeshpa@redhat.com>
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 30, 2025
@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented May 30, 2025

/label OADP

@openshift-ci openshift-ci bot added the OADP Label for all OADP PRs label May 30, 2025
@shdeshpa07 shdeshpa07 mentioned this pull request May 30, 2025
Merged
1 task
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 30, 2025

🤖 Fri May 30 11:30:39 - Prow CI generated the docs preview:

https://93978--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/oadp-self-service/oadp-self-service.html
https://93978--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/oadp-self-service/oadp-self-service-namespace-admin-use-cases.html

@openshift-ci
Copy link

openshift-ci bot commented May 30, 2025

@shdeshpa07: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented May 30, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 30, 2025
@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented May 30, 2025

Hi peer-reviewer,

The SMEs have already reviewed the original PR -> #89043. And as such, this PR only focusses on uncommenting the topic map entries and a few merge review comments.

Thanks!

@michaelryanpeter
Copy link
Contributor

michaelryanpeter commented May 30, 2025

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 30, 2025
@michaelryanpeter michaelryanpeter added this to the Planned for 4.19 GA milestone May 30, 2025
michaelryanpeter
michaelryanpeter reviewed May 30, 2025
View reviewed changes
Copy link
Contributor

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In this case, feel free to ping me directly when you are ready for merge review.

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 30, 2025
@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Jun 2, 2025

LGTM. In this case, feel free to ping me directly when you are ready for merge review.

/label peer-review-done /remove-label peer-review-needed /remove-label peer-review-in-progress

Thank you @michaelryanpeter. Will do.

@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Jun 9, 2025

@michaelryanpeter - The PR is ready for merge review please. If you still have bandwidth, could you please review the PR? Thanks.

@shdeshpa07
Copy link
Contributor Author

shdeshpa07 commented Jun 9, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 9, 2025
@michaelryanpeter
Copy link
Contributor

michaelryanpeter commented Jun 9, 2025

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jun 9, 2025
@michaelryanpeter michaelryanpeter merged commit 412384f into openshift:main Jun 9, 2025
2 checks passed
@michaelryanpeter
Copy link
Contributor

michaelryanpeter commented Jun 9, 2025

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 9, 2025

@michaelryanpeter: new pull request created: #94457

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 9, 2025
Merged
@shdeshpa07 shdeshpa07 deleted the OADP-4001-Self-Service-topic-map branch July 25, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelryanpeter michaelryanpeter michaelryanpeter left review comments

Assignees

No one assigned

Labels

branch/enterprise-4.19 merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Planned for 4.19 GA

Development

Successfully merging this pull request may close these issues.

4 participants

@shdeshpa07 @ocpdocs-previewbot @michaelryanpeter @openshift-cherrypick-robot