SREP-1857 added one second wait to probes to try to solve race condition#339
Conversation
|
@luis-falcon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
- Coverage 33.60% 33.58% -0.02%
==========================================
Files 30 30
Lines 2244 2245 +1
==========================================
Hits 754 754
- Misses 1450 1451 +1
Partials 40 40
🚀 New features to boost your workflow:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abyrne55 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
BUG:
Added 1 second wait to probe in order to solve race condition on network verifier.
Why:
Though I was not able to reproduce the issue described in the card.
The race conditions seem to happen when the getty's cleanup sequences arrive after the BEGIN token is written, AWS EC2's console output capture (which appears to interpret escape sequences rather than capture raw bytes) processes the "clear screen" command and effectively erases the BEGIN token from the visible output
The curl command output and END token arrive later and appear normally since getty has fully stopped by then.
What does this PR do? / Related Issues / Jira
This PR adds a one second wait to the probes in order to try to delay the race condition and make it less likely to happen.
Checklist
eeds to be done after technical review) I've run the branch on my local, verified that the functionality is ok
How to test this PR locally / Special Instructions