Skip to content

Comments

SREP-1857 added one second wait to probes to try to solve race condition#339

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
luis-falcon:SREP-1857-network-verifier-corrupted-output
Feb 24, 2026
Merged

SREP-1857 added one second wait to probes to try to solve race condition#339
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
luis-falcon:SREP-1857-network-verifier-corrupted-output

Conversation

@luis-falcon
Copy link
Contributor

BUG:

Added 1 second wait to probe in order to solve race condition on network verifier.

Why:

Though I was not able to reproduce the issue described in the card.

The race conditions seem to happen when the getty's cleanup sequences arrive after the BEGIN token is written, AWS EC2's console output capture (which appears to interpret escape sequences rather than capture raw bytes) processes the "clear screen" command and effectively erases the BEGIN token from the visible output
The curl command output and END token arrive later and appear normally since getty has fully stopped by then.

What does this PR do? / Related Issues / Jira

This PR adds a one second wait to the probes in order to try to delay the race condition and make it less likely to happen.

Checklist

eeds to be done after technical review) I've run the branch on my local, verified that the functionality is ok

How to test this PR locally / Special Instructions

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 19, 2026

@luis-falcon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 33.58%. Comparing base (e7f38b5) to head (5991f4a).

Files with missing lines Patch % Lines
pkg/probes/dummy/dummy.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   33.60%   33.58%   -0.02%     
==========================================
  Files          30       30              
  Lines        2244     2245       +1     
==========================================
  Hits          754      754              
- Misses       1450     1451       +1     
  Partials       40       40              
Files with missing lines Coverage Δ
pkg/probes/dummy/dummy.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abyrne55
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abyrne55

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 6823ab0 into openshift:main Feb 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants