-
Notifications
You must be signed in to change notification settings - Fork 128
SDCICD-1733: [WIP] Add KrknAI chaos test results aggregator #3104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Introduces a dedicated aggregator for KrknAI chaos testing results that reduces context for LLM analysis by parsing key summary files and excluding verbose cluster data. Key features: - Parses all.csv and health_check_report.csv to extract scenario results - Extracts minimal config summary immune to key reordering from updateKrknConfig - Stores absolute paths for log artifacts enabling LLM tool access - Provides top N scenarios (by fitness), failed scenarios, and health check metrics Files: - internal/aggregator/krknai.go: Aggregator implementation - internal/aggregator/krknai_test.go: Unit tests with 8 test cases Co-authored-by: Cursor AI<cursor@cursor.sh>
|
@varunraokadaparthi: This pull request references SDCICD-1733 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: varunraokadaparthi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Introduces a new analysis mode for KrknAI chaos test results alongside the existing CI failure analysis. The engine uses LLM to analyze chaos scenarios and provide cluster resilience recommendations. Changes: - internal/analysisengine/krknai.go: KrknAI analysis engine that orchestrates aggregation, prompt rendering, LLM analysis, and result reporting for chaos test results - internal/llm/tools/tools.go: Updated tool registry to accept log artifacts directly, enabling read_file tool to access scenario files - internal/llm/tools/read_file_test.go: Updated tests to use []aggregator.LogEntry instead of *aggregator.AggregatedData - internal/prompts/templates/krknai.yaml: A dummy prompt template for chaos engineering analysis with JSON response schema The KrknAI engine: - Collects results via KrknAIAggregator - Renders prompts with scenario summaries and artifact paths - Provides LLM with read_file tool for deep-dive analysis - Writes YAML summary to results directory - Supports Slack notifications Co-authored-by: Cursor AI<cursor@cursor.sh>
|
@varunraokadaparthi: This pull request references SDCICD-1733 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@varunraokadaparthi: This pull request references SDCICD-1733 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@varunraokadaparthi: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold |
| @@ -0,0 +1,452 @@ | |||
| package aggregator | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the specific implementation go in krkai package ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ritmun You mean in internal/aggregator/krkn/krknai.go?
Krkn Aggregator:
Introduces a dedicated aggregator for KrknAI chaos testing results that reduces context for LLM analysis by parsing key summary files and excluding verbose cluster data.
Key features:
Files:
Krkn Engine:
Introduces a new analysis mode for KrknAI chaos test results alongside
the existing CI failure analysis. The engine uses LLM to analyze chaos
scenarios and provide cluster resilience recommendations.
Changes:
orchestrates aggregation, prompt rendering, LLM analysis, and result
reporting for chaos test results
artifacts directly, enabling read_file tool to access scenario files
[]aggregator.LogEntry instead of *aggregator.AggregatedData
for chaos engineering analysis with JSON response schema
The KrknAI engine:
Co-authored-by: Cursor AIcursor@cursor.sh