Skip to content

Comments

Enable e2e tests with CCM functionality for Azure platform#20161

Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
lobziik:azure-e2e-ccm
Jul 22, 2021
Merged

Enable e2e tests with CCM functionality for Azure platform#20161
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
lobziik:azure-e2e-ccm

Conversation

@lobziik
Copy link
Contributor

@lobziik lobziik commented Jul 14, 2021 •
edited
Loading

  • e2e tests workflow
  • install with enabled featuregate (optional)

Depends on openshift/machine-config-operator#2669
Installation with feature gate also needed: openshift/machine-config-operator#2668

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2021
@openshift-ci openshift-ci bot requested review from Danil-Grigorev and elmiko July 14, 2021 09:13
@lobziik
Copy link
Contributor Author

lobziik commented Jul 15, 2021

/test pj-rehearse

Denis Moiseev added 2 commits July 20, 2021 14:34
Enable e2e tests with CCM functionality for Azure platform
8e56e39 
- e2e tests workflow
- install with enabled featuregate (optional)
disable azure-ccm-install job
cdf3aba
@lobziik lobziik changed the title WIP: Enable e2e tests with CCM functionality for Azure platform Enable e2e tests with CCM functionality for Azure platform Jul 20, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2021
Fedosin
Fedosin reviewed Jul 20, 2021
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could we exclude mandre and mdbooth from owners. They are from OpenStack team and don't need access to Azure worflows.

elmiko
elmiko reviewed Jul 20, 2021
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed with @Fedosin , otherwise lgtm

@lobziik lobziik requested review from Fedosin and elmiko July 20, 2021 13:15
elmiko
elmiko reviewed Jul 20, 2021
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2021
Fedosin
Fedosin reviewed Jul 20, 2021
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lobziik
Copy link
Contributor Author

lobziik commented Jul 20, 2021

/assign @abhinavdahiya :) Please, take a look...

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2021

@lobziik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-cloud-controller-manager-operator/master/e2e-azure-ccm-install 36abc1aa54ae5af10321a703eac8b6f2a49229a9 link /test pj-rehearse
ci/rehearse/openshift/cluster-cloud-controller-manager-operator/release-4.9/e2e-aws-ccm-install 6b2a97f link /test pj-rehearse
ci/prow/pj-rehearse 6b2a97f link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Jul 22, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, elmiko, Fedosin, lobziik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2021
@openshift-merge-robot openshift-merge-robot merged commit c8d0ab0 into openshift:master Jul 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2021

@lobziik: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-cloud-controller-manager-operator-master.yaml using file ci-operator/config/openshift/cluster-cloud-controller-manager-operator/openshift-cluster-cloud-controller-manager-operator-master.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-cloud-controller-manager-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-cloud-controller-manager-operator/openshift-cluster-cloud-controller-manager-operator-master-presubmits.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key ccm-conf-apply-feature-gate-commands.sh using file ci-operator/step-registry/ccm/conf/apply-feature-gate/ccm-conf-apply-feature-gate-commands.sh
    • key ccm-conf-pre-create-feature-gate-commands.sh using file ci-operator/step-registry/ccm/conf/pre-create-feature-gate/ccm-conf-pre-create-feature-gate-commands.sh
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/azure/ccm/OWNERS
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/azure/ccm/install/OWNERS
    • key openshift-e2e-azure-ccm-install-workflow.metadata.json using file ci-operator/step-registry/openshift/e2e/azure/ccm/install/openshift-e2e-azure-ccm-install-workflow.metadata.json
    • key openshift-e2e-azure-ccm-install-workflow.yaml using file ci-operator/step-registry/openshift/e2e/azure/ccm/install/openshift-e2e-azure-ccm-install-workflow.yaml
    • key openshift-e2e-azure-ccm-workflow.metadata.json using file ci-operator/step-registry/openshift/e2e/azure/ccm/openshift-e2e-azure-ccm-workflow.metadata.json
    • key openshift-e2e-azure-ccm-workflow.yaml using file ci-operator/step-registry/openshift/e2e/azure/ccm/openshift-e2e-azure-ccm-workflow.yaml
Details

In response to this:

  • e2e tests workflow
  • install with enabled featuregate (optional)

Depends on openshift/machine-config-operator#2669
Installation with feature gate also needed: openshift/machine-config-operator#2668

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Danil-Grigorev Danil-Grigorev Awaiting requested review from Danil-Grigorev

2 more reviewers

@elmiko elmiko elmiko left review comments

@Fedosin Fedosin Fedosin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@elmiko elmiko

@Fedosin Fedosin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lobziik @abhinavdahiya @elmiko @Fedosin @openshift-merge-robot