-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add tide for the oadp-1.4 branch for oadp-non-admin #69404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tide for the oadp-1.4 branch for oadp-non-admin #69404
Conversation
Adds Tide config for the oadp-1.4 branch of the migtools/oadp-non-admin project. Removes squash method to ensure rebasebot functions properly on that repository. Signed-off-by: Michal Pryc <mpryc@redhat.com>
|
[REHEARSALNOTIFIER] |
|
Why rebasebot is needed in this repo? |
See V wave in the https://github.com/oadp-rebasebot/oadp-rebase/blob/oadp-dev/README.md Green color - update go.mod deps only to point to rebased previous libs. Rebasebot will allow to do this once the openshift-eng/rebasebot#67 is implemented. I know it's also possible to not use rebasebot for simple go.mod updates, but this allows same workflow for all other projects. |
|
/lgtm |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mpryc, shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mpryc: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@mpryc: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Adds Tide config for the oadp-1.4 branch of the migtools/oadp-non-admin project. Removes squash method to ensure rebasebot functions properly on that repository. Signed-off-by: Michal Pryc <mpryc@redhat.com>
Adds Tide config for the oadp-1.4 branch of the migtools/oadp-non-admin project. Removes squash method to ensure rebasebot functions properly on that repository. Signed-off-by: Michal Pryc <mpryc@redhat.com>
Adds Tide config for the oadp-1.4 branch of the migtools/oadp-non-admin project.
Removes squash method to ensure rebasebot functions properly on that repository.
PR in need: migtools/oadp-non-admin#314