Skip to content

Conversation

@mpryc
Copy link
Contributor

@mpryc mpryc commented Sep 17, 2025

Adds Tide config for the oadp-1.4 branch of the migtools/oadp-non-admin project.

Removes squash method to ensure rebasebot functions properly on that repository.

PR in need: migtools/oadp-non-admin#314

Adds Tide config for the oadp-1.4 branch of the
migtools/oadp-non-admin project.

Removes squash method to ensure rebasebot functions
properly on that repository.

Signed-off-by: Michal Pryc <mpryc@redhat.com>
@openshift-ci openshift-ci bot requested review from kaovilai and mrnold September 17, 2025 21:13
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mpryc: no rehearsable tests are affected by this change

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 17, 2025
@kaovilai
Copy link
Member

Why rebasebot is needed in this repo?

@mpryc
Copy link
Contributor Author

mpryc commented Sep 18, 2025

Why rebasebot is needed in this repo?

See V wave in the https://github.com/oadp-rebasebot/oadp-rebase/blob/oadp-dev/README.md

Green color - update go.mod deps only to point to rebased previous libs. Rebasebot will allow to do this once the openshift-eng/rebasebot#67 is implemented. I know it's also possible to not use rebasebot for simple go.mod updates, but this allows same workflow for all other projects.

@kaovilai
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2025
@mpryc
Copy link
Contributor Author

mpryc commented Sep 22, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mpryc, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2025

@mpryc: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit cc5702d into openshift:master Sep 22, 2025
10 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2025

@mpryc: Updated the config configmap in namespace ci at cluster app.ci using the following files:

  • key core-services-prow-02_config-migtools-oadp-non-admin-_prowconfig.yaml using file core-services/prow/02_config/migtools/oadp-non-admin/_prowconfig.yaml
Details

In response to this:

Adds Tide config for the oadp-1.4 branch of the migtools/oadp-non-admin project.

Removes squash method to ensure rebasebot functions properly on that repository.

PR in need: migtools/oadp-non-admin#314

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

xiaojiey pushed a commit to xiaojiey/release that referenced this pull request Sep 25, 2025
Adds Tide config for the oadp-1.4 branch of the
migtools/oadp-non-admin project.

Removes squash method to ensure rebasebot functions
properly on that repository.

Signed-off-by: Michal Pryc <mpryc@redhat.com>
abhay-nutanix pushed a commit to abhay-nutanix/release that referenced this pull request Oct 16, 2025
Adds Tide config for the oadp-1.4 branch of the
migtools/oadp-non-admin project.

Removes squash method to ensure rebasebot functions
properly on that repository.

Signed-off-by: Michal Pryc <mpryc@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants