Skip to content

Comments

NO-JIRA: Add verify job for manifest-gen enabled CAPI repositories#73565

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
RadekManak:capi-verify
Jan 19, 2026
Merged

NO-JIRA: Add verify job for manifest-gen enabled CAPI repositories#73565
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
RadekManak:capi-verify

Conversation

@RadekManak
Copy link
Contributor

@RadekManak RadekManak commented Jan 15, 2026 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 15, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 15, 2026

@RadekManak: This pull request explicitly references no jira issue.

Details

In response to this:

Adds presubmit for generic verify target in CAPI repositories. Currently, we want to verify that generated manifests are updated.

Requires PRs with verify target in openshift/Makefile

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from chrischdi and damdo January 15, 2026 11:49
@RadekManak RadekManak mentioned this pull request Jan 15, 2026
Closed
6 tasks
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 15, 2026

@RadekManak: This pull request explicitly references no jira issue.

Details

In response to this:

Adds presubmit for generic verify target in CAPI repositories. Currently, we want to verify that generated manifests are updated.

Requires PRs with verify target in openshift/Makefile

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 15, 2026

@RadekManak: This pull request explicitly references no jira issue.

Details

In response to this:

Adds presubmit for generic verify target in CAPI repositories. Currently, we want to verify that generated manifests are updated.

Requires PRs with verify target in openshift/Makefile

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@damdo
Copy link
Member

damdo commented Jan 15, 2026

/assign @honza

damdo
damdo reviewed Jan 15, 2026
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RadekManak we'll need to add the openshift/cluster-api job config also here

@RadekManak RadekManak force-pushed the capi-verify branch 2 times, most recently from 50be68b to 52409f6 Compare January 15, 2026 17:24
@honza
Copy link
Member

honza commented Jan 15, 2026

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2026
@damdo
Copy link
Member

damdo commented Jan 16, 2026

/pj-rehearse pull-ci-openshift-cluster-api-provider-aws-main-verify pull-ci-openshift-cluster-api-provider-azure-master-verify pull-ci-openshift-cluster-api-master-verify pull-ci-openshift-cluster-api-provider-ibmcloud-main-verify pull-ci-openshift-cluster-api-provider-vsphere-master-verify

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2026

@damdo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2026

[REHEARSALNOTIFIER]
@RadekManak: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-api-provider-vsphere-master-verify openshift/cluster-api-provider-vsphere presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-gcp-master-verify openshift/cluster-api-provider-gcp presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-ibmcloud-main-verify openshift/cluster-api-provider-ibmcloud presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-main-verify openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-metal3-main-verify openshift/cluster-api-provider-metal3 presubmit Presubmit changed
pull-ci-openshift-cluster-api-master-verify openshift/cluster-api presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-azure-master-verify openshift/cluster-api-provider-azure presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@RadekManak
Copy link
Contributor Author

RadekManak commented Jan 19, 2026

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2026

@RadekManak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RadekManak
Copy link
Contributor Author

RadekManak commented Jan 19, 2026

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2026

@RadekManak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RadekManak
Copy link
Contributor Author

RadekManak commented Jan 19, 2026

/pj-rehearse pull-ci-openshift-cluster-api-provider-metal3-main-verify

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2026

@RadekManak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RadekManak
Copy link
Contributor Author

RadekManak commented Jan 19, 2026

metal3 is broken due to error in gitignore. Fixed in openshift/cluster-api-provider-metal3#59

@RadekManak
Copy link
Contributor Author

RadekManak commented Jan 19, 2026

/pj-rehearse pull-ci-openshift-cluster-api-provider-metal3-main-verify

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2026

@RadekManak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@damdo
Copy link
Member

damdo commented Jan 19, 2026

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2026

@damdo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 19, 2026
@damdo
Copy link
Member

damdo commented Jan 19, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, honza, RadekManak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

@RadekManak: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5be73b6 into openshift:master Jan 19, 2026
22 checks passed
dhensel-rh pushed a commit to dhensel-rh/release that referenced this pull request Feb 19, 2026
@RadekManak @dhensel-rh
Add verify job for manifest-gen enabled CAPI repositories (openshift#…
276673b 
…73565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrischdi chrischdi Awaiting requested review from chrischdi

1 more reviewer

@damdo damdo damdo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@honza honza

@damdo damdo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RadekManak @openshift-ci-robot @damdo @honza