Skip to content

Comments

[release-4.20] OCPBUGS-76957: filter ingress namespace on UnmanagedRoutes metric#74

Open
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.20from
openshift-cherrypick-robot:cherry-pick-73-to-release-4.20
Open

[release-4.20] OCPBUGS-76957: filter ingress namespace on UnmanagedRoutes metric#74
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.20from
openshift-cherrypick-robot:cherry-pick-73-to-release-4.20

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #73

/assign openshift-cherrypick-robot

/cherrypick release-4.19

Route controller triggers the UnmanagedRoutes metric whenever an
unmanaged Ingress resource owns a Route resource. An ingress is
considered managed when it points to an existing ingress class, and this
ingress class configures spec.controller as
"openshift.io/ingress-to-route" controller.

The management check was incorrectly filtering ingress resources by
missing to check its namespace, so a managed ingress that owns a router
would be considered unmanaged if an unmanaged ingress on another
namespace shares the same name.
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-76641 has been cloned as Jira Issue OCPBUGS-76957. Will retitle bug to link to clone.
/retitle [release-4.20] OCPBUGS-76957: filter ingress namespace on UnmanagedRoutes metric

Details

In response to this:

This is an automated cherry-pick of #73

/assign openshift-cherrypick-robot

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.20] OCPBUGS-76641: filter ingress namespace on UnmanagedRoutes metric [release-4.20] OCPBUGS-76957: filter ingress namespace on UnmanagedRoutes metric Feb 16, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 16, 2026
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-76957, which is invalid:

  • expected dependent Jira Issue OCPBUGS-76641 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #73

/assign openshift-cherrypick-robot

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from Miciah and knobunc February 16, 2026 17:22
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign ironcladlou for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2026

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@melvinjoseph86
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 19, 2026
@openshift-ci-robot
Copy link
Contributor

@melvinjoseph86: This pull request references Jira Issue OCPBUGS-76957, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-76641 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-76641 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
  • bug has dependents

Requesting review from QA contact:
/cc @melvinjoseph86

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@melvinjoseph86
Copy link

melvinjoseph86 commented Feb 19, 2026

Verified using cluster bot

➜   oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.20.0-0-2026-02-19-071859-test-ci-ln-6mlfpxb-latest   True        False         38m     Cluster version is 4.20.0-0-2026-02-19-071859-test-ci-ln-6mlfpxb-latest

➜   cat my-service.yaml
apiVersion: v1
kind: Service
metadata:
  name: my-service
spec:
  selector:
    app: my-app
  ports:
  - name: http
    port: 80
    targetPort: 8080

➜  cat << EOF | oc create -f -
apiVersion: v1
kind: Namespace
metadata:
  name: managed-ns
---
apiVersion: v1
kind: Namespace
metadata:
  name: unmanaged-ns
EOF
namespace/managed-ns created
namespace/unmanaged-ns created

➜  oc apply -n managed-ns   -f my-service.yaml
oc apply -n unmanaged-ns -f my-service.yaml
service/my-service created
service/my-service created
➜  cat << EOF | oc create -f- 
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: example-ingress
  namespace: managed-ns
spec:
  ingressClassName: openshift-default
  rules:
  - host: managed.apps.example.com
    http:
      paths:
      - path: /
        pathType: Prefix
        backend:
          service:
            name: my-service
            port:
              number: 80
EOF

ingress.networking.k8s.io/example-ingress created
➜  cat << EOF | oc create -f-
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: example-ingress
  namespace: unmanaged-ns
spec:
  ingressClassName: fake-ingress-class
  rules:
  - host: unmanaged.apps.example.com
    http:
      paths:
      - path: /
        pathType: Prefix
        backend:
          service:
            name: my-service
            port:
              number: 80
EOF
ingress.networking.k8s.io/example-ingress created
➜  oc get Ingress -A 
NAMESPACE      NAME              CLASS                HOSTS                        ADDRESS                                                          PORTS   AGE
managed-ns     example-ingress   openshift-default    managed.apps.example.com     router-default.apps.ci-ln-6mlfpxb-76ef8.aws-2.ci.openshift.org   80      11s
unmanaged-ns   example-ingress   fake-ingress-class   unmanaged.apps.example.com                                                                    80      5s
➜  oc get route -A
NAMESPACE                  NAME                      HOST/PORT                                                                                      PATH        SERVICES            PORT    TERMINATION            WILDCARD
managed-ns                 example-ingress-zvj99     managed.apps.example.com                                                                       /           my-service          http                           None
openshift-authentication   oauth-openshift           oauth-openshift.apps.ci-ln-6mlfpxb-76ef8.aws-2.ci.openshift.org    
<----skip--->
Screenshot 2026-02-19 at 2 29 09 PM

There is no "UnmanagedRoutes" alerts in their cluster,hence marking as verified
/verified by @mjoseph

@melvinjoseph86
Copy link

for not fixed cluster there is metric count like this
Screenshot 2026-02-18 at 10 12 46 PM

@melvinjoseph86
Copy link

/verified by @mjoseph

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 19, 2026
@openshift-ci-robot
Copy link
Contributor

@melvinjoseph86: This PR has been marked as verified by @mjoseph.

Details

In response to this:

/verified by @mjoseph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants