Skip to content

Comments

OCPBUGS-68220: Update logrus to 1.9.3 to address CVE-2025-65637#316

Open
davegord wants to merge 1 commit intoopenshift:release-4.17from
davegord:fix-logrus-cve-4.17
Open

OCPBUGS-68220: Update logrus to 1.9.3 to address CVE-2025-65637#316
davegord wants to merge 1 commit intoopenshift:release-4.17from
davegord:fix-logrus-cve-4.17

Conversation

@davegord
Copy link

@davegord davegord commented Feb 4, 2026

Summary

  • Updates github.com/sirupsen/logrus from v1.9.0 to v1.9.3
  • Fixes CVE-2025-65637 security vulnerability in the logrus logging library

Changes

  • Updated go.mod with logrus v1.9.3
  • Ran go mod tidy and go mod vendor to update dependencies
  • Vendored updated logrus package with security fix

Test plan

  • Verify go.mod and go.sum changes are correct
  • Run unit tests
  • Build the operator
  • Deploy and verify functionality

🤖 Generated with Claude Code


Note

Low Risk
Low risk dependency update focused on a vendored logging library; main impact is in logrus WriterLevel scanning behavior, which could slightly change log line splitting/formatting for very large writes.

Overview
Updates vendored github.com/sirupsen/logrus from v1.9.0 to v1.9.3 (including go.mod/go.sum/vendor/modules.txt) to pick up the CVE fix.

The updated logrus writer.go changes how Entry.WriterLevel reads from the pipe: it configures the scanner to safely handle large inputs (chunking up to bufio.MaxScanTokenSize) and trims trailing \r\n before logging, plus minor README/vendor doc adjustments.

Written by Cursor Bugbot for commit c573cef. This will update automatically on new commits. Configure here.

Cursor Bugbot reviewed your changes and found no issues for commit c573cef

This updates the github.com/sirupsen/logrus dependency from v1.9.0
to v1.9.3 to fix CVE-2025-65637, a security vulnerability in the
logrus logging library.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Feb 4, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@davegord davegord changed the title Update logrus to 1.9.3 to address CVE-2025-65637 OCPBUGS-68220: Update logrus to 1.9.3 to address CVE-2025-65637 Feb 4, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 4, 2026
@openshift-ci-robot
Copy link
Contributor

@davegord: This pull request references Jira Issue OCPBUGS-68220, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-68220 to depend on a bug targeting a version in 4.18.0, 4.18.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • Updates github.com/sirupsen/logrus from v1.9.0 to v1.9.3
  • Fixes CVE-2025-65637 security vulnerability in the logrus logging library

Changes

  • Updated go.mod with logrus v1.9.3
  • Ran go mod tidy and go mod vendor to update dependencies
  • Vendored updated logrus package with security fix

Test plan

  • Verify go.mod and go.sum changes are correct
  • Run unit tests
  • Build the operator
  • Deploy and verify functionality

🤖 Generated with Claude Code


[!NOTE]
Low Risk
Low risk dependency update focused on a vendored logging library; main impact is in logrus WriterLevel scanning behavior, which could slightly change log line splitting/formatting for very large writes.

Overview
Updates vendored github.com/sirupsen/logrus from v1.9.0 to v1.9.3 (including go.mod/go.sum/vendor/modules.txt) to pick up the CVE fix.

The updated logrus writer.go changes how Entry.WriterLevel reads from the pipe: it configures the scanner to safely handle large inputs (chunking up to bufio.MaxScanTokenSize) and trims trailing \r\n before logging, plus minor README/vendor doc adjustments.

Written by Cursor Bugbot for commit c573cef. This will update automatically on new commits. Configure here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from deads2k February 4, 2026 21:52
@davegord
Copy link
Author

davegord commented Feb 4, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 4, 2026
@openshift-ci-robot
Copy link
Contributor

@davegord: This pull request references Jira Issue OCPBUGS-68220, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-75924 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-75924 targets the "4.18.z" version, which is one of the valid target versions: 4.18.0, 4.18.z
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

@davegord: This pull request references Jira Issue OCPBUGS-68220, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-75924 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-75924 targets the "4.18.z" version, which is one of the valid target versions: 4.18.0, 4.18.z
  • bug has dependents
Details

In response to this:

Summary

  • Updates github.com/sirupsen/logrus from v1.9.0 to v1.9.3
  • Fixes CVE-2025-65637 security vulnerability in the logrus logging library

Changes

  • Updated go.mod with logrus v1.9.3
  • Ran go mod tidy and go mod vendor to update dependencies
  • Vendored updated logrus package with security fix

Test plan

  • Verify go.mod and go.sum changes are correct
  • Run unit tests
  • Build the operator
  • Deploy and verify functionality

🤖 Generated with Claude Code


[!NOTE]
Low Risk
Low risk dependency update focused on a vendored logging library; main impact is in logrus WriterLevel scanning behavior, which could slightly change log line splitting/formatting for very large writes.

Overview
Updates vendored github.com/sirupsen/logrus from v1.9.0 to v1.9.3 (including go.mod/go.sum/vendor/modules.txt) to pick up the CVE fix.

The updated logrus writer.go changes how Entry.WriterLevel reads from the pipe: it configures the scanner to safely handle large inputs (chunking up to bufio.MaxScanTokenSize) and trims trailing \r\n before logging, plus minor README/vendor doc adjustments.

Written by Cursor Bugbot for commit c573cef. This will update automatically on new commits. Configure here.

Cursor Bugbot reviewed your changes and found no issues for commit c573cef

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dusk125
Copy link

dusk125 commented Feb 17, 2026

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2026

@davegord: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dusk125
Copy link

dusk125 commented Feb 17, 2026

/lgtm
/label backport-risk-assessed
/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 17, 2026
@openshift-ci-robot
Copy link
Contributor

@dusk125: This PR has been marked as verified by ci.

Details

In response to this:

/lgtm
/label backport-risk-assessed
/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2026

@dusk125: The label(s) backport-risk-assessed cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: openshift-patch-managers, openshift-release-oversight, openshift-staff-engineers, openshift-sustaining-engineers

Details

In response to this:

/lgtm
/label backport-risk-assessed
/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2026
@benluddy benluddy added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2026
@benluddy
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 18, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: davegord, dusk125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dusk125
Copy link

dusk125 commented Feb 19, 2026

@coderabbitai skip

@coderabbitai
Copy link

coderabbitai bot commented Feb 19, 2026

@dusk125: Understood! I'll skip reviewing this PR. Automatic reviews have been paused.

✅ Actions performed

Reviews paused.

@dusk125
Copy link

dusk125 commented Feb 19, 2026

@coderabbitai help

@coderabbitai
Copy link

coderabbitai bot commented Feb 19, 2026

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

CodeRabbit commands

These commands are invoked using PR/Issue comments.

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai evaluate custom pre-merge check --instructions <custom-checks-instructions> --name <custom-checks-title> [--mode <error|warning>] to validate the custom pre-merge checks instructions. Defaults to error when --mode is omitted.
    • @coderabbitai ignore pre-merge checks to override pre-merge checks and get an approval on PR.
    • @coderabbitai run pre-merge checks to run pre-merge checks on the pull request.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai generate configuration to create a PR that adds the current resolved configuration as .coderabbit.yaml (or show it if already present).
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, support, documentation and community

  • Visit our status page to check the current availability of CodeRabbit.
  • Create a ticket on our support page for assistance with any issues or questions.
  • Visit our documentation site for detailed information on how to use CodeRabbit.
  • Join our Discord community to connect with other users and get help from the community.
  • Follow us on X/Twitter for updates and announcements.

@dusk125
Copy link

dusk125 commented Feb 19, 2026

@coderabbitai ignore

@coderabbitai
Copy link

coderabbitai bot commented Feb 19, 2026

✅ Actions performed

Reviews paused.

@dusk125
Copy link

dusk125 commented Feb 19, 2026

@benluddy can you override the coderabbit review?

@dusk125
Copy link

dusk125 commented Feb 20, 2026

@coderabbitai resume

@coderabbitai
Copy link

coderabbitai bot commented Feb 20, 2026

✅ Actions performed

Reviews resumed.

@dusk125
Copy link

dusk125 commented Feb 20, 2026

@coderabbitai resolve

@coderabbitai
Copy link

coderabbitai bot commented Feb 20, 2026

✅ Actions performed

Comments resolved. Auto-approval is disabled; enable reviews.request_changes_workflow to approve automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants