Reconsider use of never-stable, add techpreview variant#259
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom Aug 31, 2021
Merged
Reconsider use of never-stable, add techpreview variant#259openshift-merge-robot merged 2 commits intoopenshift:masterfrom
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
bparees
reviewed
Aug 18, 2021
Member
Author
|
/hold Hold for now, I want to make sure no one else is finding never-stable useful |
openshift-ci
bot
added
the
do-not-merge/hold
stbenjam
changed the title
Member
Author
|
I asked on slack and got no opinions about never-stable, so I think it's better to use it more sparingly. /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
bparees
reviewed
Aug 19, 2021
stbenjam
force-pushed
the
variants
branch
2 times, most recently
from
2891a0f to
cbc3c90
Compare
- I haven't found being more liberal with adding jobs to the never-stable list to be particularly helpful, especially with so many failing. I think each should be investigated, and a bug filed -- and then added to the never-stable list. - Adds a new techpreview variant, for TPNU jobs
Member
Author
|
Ok this should be ready now |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't found being more liberal with adding jobs to the never-stable
list to be particularly helpful, especially with so many failing. I
think each should be investigated, and a bug filed -- and then added to
the never-stable list.
Exclude never-stable jobs from home page widgets
Adds a new techpreview variant, for TPNU jobs (being added in [OCPCLOUD-1201] Add periodics for TechPreviewNoUpgrade clusters release#19845)