coverage: emit zero for missing metrics from coverage show output #33
+43
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ovs-appctl coverage/show command only reports counters that have non-zero values. This causes the exporter to not emit metrics that have not incremented yet, making it difficult to set up alerts for error conditions before they occur. Changes done to iterate over all defined metrics and emit 0 for any not present in the OVS output. Further, changes done in test comparison logic to handle the exporter now reporting more fields than what OVS returns. Signed-off-by: Abhiram R N <abhiramrn@gmail.com>
abhiramnarayana
force-pushed
the
emitzerometrics
branch
from
426d8e0 to
81d3440
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ovs-appctl coverage/show command only reports counters that have non-zero values. This causes the exporter to not emit metrics that have not incremented yet, making it difficult to set up alerts for error conditions before they occur.
Changes done to iterate over all defined metrics and emit 0 for any not present in the OVS output.
Further, changes done in test comparison logic to handle the exporter now reporting more fields than what OVS returns.