refactor: standardize MechId naming convention #2322
Closed
+175
−175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses inconsistent naming of mechanism identifiers across the codebase. Changes: - Rename `sub_id` parameter to `mecid` in public API functions - Rename `get_netuid_and_subid` to `get_netuid_and_mecid` - Update variable names from `sub_id_*` to `mecid_*` in mechanism.rs - Update comments to use `mecid` terminology instead of `sub_id` - Rename `sub_weight`/`sub_emission` to `mech_weight`/`mech_emission` This aligns internal implementation with the public-facing API which already uses `mecid` and `MechId` consistently. Fixes opentensor#2101
Contributor
Author
|
@sam0x17 would you review this PR? |
Contributor
|
should be |
Contributor
Author
|
Thanks for the review @sam0x17 You're right I'll update |
Renamed all occurrences of 'mecid' to 'mechid' (mechanism ID) for clarity and consistency as requested by @sam0x17.
Contributor
Author
|
Hey @sam0x17, thanks again for catching that naming issue I pushed the fix. |
Contributor
Author
|
Closing to focus on other contributions. Will revisit later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sub_idparameter tomecidin public API functions to match theMechIdtypeget_netuid_and_subidfunction toget_netuid_and_mecidsub_id_*tomecid_*mecidterminologyChanges
Files modified:
pallets/subtensor/src/subnets/mechanism.rs- Core naming changespallets/subtensor/src/epoch/run_epoch.rs- Updated function callspallets/subtensor/src/subnets/weights.rs- Updated function callspallets/subtensor/src/migrations/migrate_crv3_commits_add_block.rs- Updated function callspallets/subtensor/src/tests/mechanism.rs- Updated test callsTest plan
cargo check --libpassescargo check --testspassesFixes #2101
Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=101010297