-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add tiny-editor submodule #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughAdds Tiny Editor as a Git submodule and integrates its docs into the site: VitePress sidebar and rewrite routes for guide/demo/api/modules, a new product tab in the header, and a nav-tab class and path mapping for /tiny-editor/. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.vitepress/theme/components/CustomHeader.vue:
- Around line 344-354: productPathMap currently uses generic segments which
cause false matches; update the arrays in productPathMap (referencing the
productPathMap constant) so each product uses product-prefixed paths (e.g.
change "tiny-robot" entries to "/tiny-robot/components/" and
"/tiny-robot/tools/" and "tiny-editor" entries to "/tiny-editor/demo/",
"/tiny-editor/api/", "/tiny-editor/modules/"); keep the same downstream logic
that builds segments, uses isProductRoute (the segments.some(...) check against
route.path) and assigns activeNavTab so behavior remains the same but matching
is unambiguous.
- Around line 473-480: The TinyEditor tab object (key "tiny-editor") uses the
wrong asset name in the src expression: change the filename fragment from
"tiny-engine" to "tiny-editor" inside the src template string that references
activeProductTab.value, so it builds URLs like logo-active-tiny-editor.svg and
logo-normal-tiny-editor.svg; also ensure the corresponding files
(logo-active-tiny-editor.svg and logo-normal-tiny-editor.svg) are added under
public/images/ before deploying the change so the new src paths resolve
correctly.
🧹 Nitpick comments (2)
.vitepress/theme/entity/nav-tab.ts (1)
117-117: Minor: Extra blank line before export.There's an extra blank line before the export statement that differs from the existing code style.
🧹 Suggested cleanup
- - export { NavTabFactory }.vitepress/theme/components/CustomHeader.vue (1)
508-510: Minor: Formatting inconsistency.Missing space between
}andelseon line 510.🧹 Suggested fix
} else if (path.includes("/tiny-editor/")) { activeProductTab.value = "tiny-editor"; - }else { + } else { activeProductTab.value = ""; }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.vitepress/theme/components/CustomHeader.vue:
- Line 34: The search button's title is incorrect: update the button that calls
openSearch (the element with `@click`="openSearch") to use an appropriate title
like "Open search" or "Search" instead of "Toggle theme" so screen readers and
tooltips reflect its action; locate the button in CustomHeader.vue that binds
`@click`="openSearch" and replace the title attribute accordingly.
- Around line 489-491: The else branch after the path check has inconsistent
spacing ("}else {"); update the conditional formatting in the CustomHeader.vue
fragment so it matches the file style by changing the token sequence to "} else
{" where the code checks path.includes("/tiny-editor/") and sets
activeProductTab.value = "tiny-editor". Ensure only the spacing is changed and
no logic is modified.
Summary by CodeRabbit