Skip to content

Clean session disconnect event even if an error occurs#625

Open
enricop89 wants to merge 4 commits intodevelopfrom
fix-double-listener-disconnect-session
Open

Clean session disconnect event even if an error occurs#625
enricop89 wants to merge 4 commits intodevelopfrom
fix-double-listener-disconnect-session

Conversation

@enricop89
Copy link
Contributor

This PR fixes #271.

Credits: @vineus

@vineus
Copy link

vineus commented Nov 25, 2022

Thanks a lot for the PR! 🙇

Will test it

@vineus
Copy link

vineus commented Nov 28, 2022

@enricop89 it works perfectly Thanks a ton!

@pietgk
Copy link
Contributor

pietgk commented Jan 2, 2023

@enricop89 @abdulajet will this PR be merged?

@enricop89 enricop89 changed the base branch from 0.21.2 to 0.21.4 March 24, 2023 09:37
@enricop89 enricop89 requested a review from jeffswartz March 24, 2023 09:38
@marinaserranomontes marinaserranomontes changed the base branch from 0.21.4 to develop October 27, 2023 16:57
@marinaserranomontes marinaserranomontes changed the base branch from develop to 0.21.4 October 27, 2023 16:57
@pietgk
Copy link
Contributor

pietgk commented Nov 29, 2023

Why is this PR not merged?

@evillemez
Copy link
Contributor

evillemez commented Jan 6, 2025

Is there any chance of this being merged? #271 Is a long-standing issue which, despite having been closed, is still a real problem.

@makhdoomimran-10P
Copy link

We really need this to be merged.

@pietgk
Copy link
Contributor

pietgk commented Jan 21, 2025

@abdulajet @jeffswartz is it possible to give a little bit more attention to react-native.
We are feeling more and more pain of not getting the quality we need from a paid product.
So please be kind and at least comment on this PR.
Thx in advance.

@t4ngth00
Copy link

t4ngth00 commented Oct 6, 2025

@jeffswartz could you please review this PR? As stated by others, this issue is a long-standing one, and we currently have to use this patch for our production application.

@joliveraortega
Copy link
Contributor

@pietgk @t4ngth00 Is this still needed? If so we are happy to take it to the finish line. Please, let's know. Thanks!

@pietgk
Copy link
Contributor

pietgk commented Feb 6, 2026

@joliveraortega i see nothing that would mark this as solved. so yes put in the effort and please review and get this ticket finally solved please.

@joliveraortega
Copy link
Contributor

@pietgk Thanks for answering. I can see it is not marked as solved. I was asking given this is aged issue. I am new here and am catching up. Will prioritise this accordingly. Thanks.

@joliveraortega joliveraortega changed the base branch from 0.21.4 to develop February 11, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants