Skip to content

Add sensors for heating.power.consumption dhw+heating+total #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tlinnet wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Add sensors for heating.power.consumption dhw+heating+total #667

tlinnet wants to merge 25 commits into from

Conversation

@tlinnet
Copy link

@tlinnet tlinnet commented Nov 20, 2025

@tescnovonesis
Adding sensors for heating.power.consumption.dhw, heating.power.consu…
8be56ae 
…mption.heating and heating.power.consumption.total
@tescnovonesis
Adding test response file for Vitocal252A
26ba9d5
@tescnovonesis
Sorted Vitocal252A.json with jq, according to README
adf6bfb
@tescnovonesis
Implementing initial tests for Vitocal252A. Copied from Vitocal250A a…
2f60fff 
…nd adjusted
@tescnovonesis
Implemented test for Power Consumption Heating
8725f4d
@tescnovonesis
Implemented tests for Total power consumption
acf9a62
@tescnovonesis
Adding test for Power consumption for Domestic Hot Water
1b79f67
@tescnovonesis
Merge branch 'master' into core_issue_155695
43f9fd8
@tescnovonesis
Align naming on tests
f51e092
@tescnovonesis
Update of test for Vitocal252A, after ViCare API had Maintenance wind…
b00e90d 
…ow 2025-11-18. That seems to have fixed some values
@tescnovonesis
Adding missing Properties for tests. Marked under '# heating - not ye…
94b50e7 
…t used'
@tescnovonesis
Adding sensors to GazBoiler
9b4fc8e
@tescnovonesis
Adding another test for GazBoiler
850912d
@tescnovonesis
Fix for some GazBoilers have unit in another dict
4a42e62
@tescnovonesis
Added additional test for FuelCell
e4a9e43
@tescnovonesis
Adding sensors to fuelcell
b30d661
@tescnovonesis
adding extra test for Gaz boiler
902e602
@tescnovonesis
Adding additional tests
a42c7f5
CFenner
CFenner reviewed Nov 20, 2025
View reviewed changes
tlinnet and others added 4 commits November 21, 2025 07:42
@tlinnet @CFenner
Update PyViCare/PyViCareHeatPump.py
ca7b995 
def getPowerConsumptionHeatingYear(self):
    def getPowerConsumptionHeatingThisYear(self):

Co-authored-by: Christopher Fenner <9592452+CFenner@users.noreply.github.com>
@tescnovonesis
Renaming getPowerConsumptionHeatingYear to getPowerConsumptionHeating…
8f3f8ab 
…ThisYear
@tescnovonesis
Fix for missing return, after implementation of fetching Unit of kilo…
25aeb6f 
…wattHour, that can be stored in either properties.day.unit or properties.unit.value
@tescnovonesis
Renamed getPowerConsumptionDomesticHotWaterYear to getPowerConsumptio…
8e76b0e 
…nDomesticHotWaterThisYear
@tlinnet
Copy link
Author

tlinnet commented Nov 21, 2025

There was one thing I was unsure abouat

grep " def " PyViCareHeatPump.py | cut -d" " -f6 | cut -d"(" -f1 | sort | uniq -d shows that some function definitions are made multiple times

getLiquidTemperature
getLiquidTemperatureUnit
getPowerConsumptionCoolingThisYear
getPowerConsumptionHeatingThisYear

Not sure if this could be an issue.
Test cases are running as expected

@tlinnet
Copy link
Author

tlinnet commented Nov 22, 2025

Merge from upstream

@tlinnet tlinnet mentioned this pull request Nov 22, 2025
Open
CFenner
CFenner reviewed Nov 26, 2025
View reviewed changes
@tescnovonesis
pylint Fix C0304: Final newline missing (missing-final-newline) in te…
0982c91 
…st_Vitodens200W, test_Vitodens200W_B2HF, test_Vitodens222W, test_Vitodens300W
@tescnovonesis
pylint Fix C0303: Trailing whitespace (trailing-whitespace) in test_V…
513402b 
…itovalorPT2, line 110, column 20
@tlinnet
Copy link
Author

tlinnet commented Nov 28, 2025

Hi @CFenner .
What would be needed to move this forward?

@tlinnet tlinnet mentioned this pull request Nov 30, 2025
Open
@tlinnet
Copy link
Author

tlinnet commented Dec 1, 2025

Hi @CFenner

I tested the PR, by setting up vicare in homeassistant/custom_components, and adding the new sensors.
This seems now to work as expected

image

@tlinnet
Copy link
Author

tlinnet commented Dec 3, 2025

Lets go :)
It's working as intended

@tlinnet
Copy link
Author

tlinnet commented Dec 7, 2025

Anyone here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CFenner CFenner CFenner left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tlinnet @CFenner @tescnovonesis