system-linux: inherit tos value in outer ip6 header #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jow-
reviewed
May 8, 2024
In case of ipip6 tunnels, inherit the tos value in the ip6 header from the inner ip4 header as the default behaviour. Without this commit, the tos value in the ip6 header is hard coded to 0 which is wrong. The ipip6 mode tunnels lack a tos uci option allowing the choice of either inheriting tos value or setting it as per uci config. I will push a change to address this separately, but, in the absense of such a config, the default behaviour should be inherit the tos value from the inner ip4 header and not to hard code it to 0. This commit fixes that. Signed-off-by: Rahul Thakur <rahul.thakur@iopsys.eu>
|
@jow- Any news on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of ipip6 tunnels, inherit the tos value in the ip6 header from the inner ip4 header as the default behaviour. Without this commit, the tos value in the ip6 header is hard coded to 0 which is wrong.
The ipip6 mode tunnels lack a tos uci option allowing the choice of either inheriting tos value or setting it as per uci config. I will push a change to address this separately, but, in the absense of such a config, the default behaviour should be inherit the tos value from the inner ip4 header and not to hard code it to 0. This commit fixes that.