Skip to content

Conversation

@wryun
Copy link

@wryun wryun commented Sep 30, 2024

This causes DHCP renewals to happen when you disconnect/reconnect cables or re-establish wifi connections on a bridge.

I suspect I haven't done this in the right way - i.e. there's some implication I'm missing from causing TOPO_CHANGE all the time, though the 'auth' code does it anyway. But it's very useful for us in two situations:

  • if we have an AP device (i.e. bridging ethernet and AP), then it means if you disconnect/reconnect the ethernet link it will request a new address (behaving in the way people would expect).
  • if we have an Extender style device (i.e. bridging ethernet and STA), then if the STA link goes does it re-requests. Why is this useful? Because the AP might have reconfigured itself in some way; in our case, switching from a router (forwarding from AP->WAN) to an AP with ethernet bridged, in which case the DHCP server available will have changed. It's also useful in the case that the AP has reset if the AP is a DHCP server, in which case its DHCP lease table will have been cleared so it's nice from a UI perspective to have the STA renew.

This causes DHCP renewals to happen when you disconnect/reconnect
cables or re-establish wifi connections on a bridge.

Signed-off-by: James Haggerty <james.haggerty@morsemicro.com>
@wryun wryun force-pushed the topo-change-on-link-up branch from 557a26b to 85bd4f9 Compare September 30, 2024 01:02
morse-arienjudge pushed a commit to MorseMicro/openwrt that referenced this pull request Mar 3, 2025
…n bridge

This causes DHCP renewals when you disconnect/reconnect cables or
re-establish wifi connections on a bridge.

openwrt/netifd#35

I think we want this, but it's a bit of a scary change that I
might be missing some implications for, so I'd like to get it
in now to give us some time to experience it.

Approved-by: Sophronia Koilpillai
Approved-by: Evan Benn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant