nut: fix driver, server, and monitor reload/stop #28382
Draft
+404
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellcheck is a useful linter if a bit pedantic and overzealous so add overrides to silence false positives Also, fix issues found by the linting. * misspelling meant initscript could skip updating configuration in certain circumstances * minor: assignment of the result of execution as the time of creating local. This has been separated. likewise cspell is useful for getting spellings right and avoiding typos, so override false positives for it as well Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
This is a noop, but since we are here. Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
Updated configuration was not being applied after config change. This was due to the means used to do the daemon reloads. Closes openwrt#28298 "Drivers not restarted on config change" Enable creating PID files for the server, driver, and monitor daemon processes. This allows to use NUT's built-in facilities for signalling the daemon's. For server, when reloading: 1. Check if upsd is running 1. If not, start it. 2. If it is send reload signal to upsd 2. For each driver: 1. Check if the driver is running 1. If it is, send reload-or-exit signal to driver 2. If driver is not running, start it 3. Attempt to start server (upsd and drivers) if service was stopped. For server, when stopping: 1. Check if upsd is running 1. If it is send stop signal to upsd 2. Ensure it really is stopped 2. For each driver: 1. Check if the driver is running 1. If it is, send stop signal to driver 2. If driver is still running, stop it. 3. If the server process is active (even with not upsd or drivers), stop it. For monitor, send the reload signal on config change, with fallback to stopping and starting the daemon. Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
danielfdickinson
force-pushed
the
pr-nut-fix-reload-on-change
branch
from
a298ac3 to
865f444
Compare
systemcrash
reviewed
Jan 19, 2026
| start_service "$@" | ||
| local should_stop_upsd | ||
| local STATEPATH=/var/run/nut | ||
| local haveserver=0 |
Contributor
There was a problem hiding this comment.
What does haveserver signify? That the file exists or it's running?
Contributor
Author
There was a problem hiding this comment.
Good point. It is that the upsd (server) configuration is present. Likewise havedriver should be haveupsconfig to differentiate between a driver and and a driver instance (which is for a specific ups). haveupsdconfig?
Contributor
There was a problem hiding this comment.
Better. Make booleans as descriptive and concise as possible, here, so it's easy to follow what we're flagging. This nut thing is not simple, which possibly explains why we're in this situation to begin with :)
Contributor
There was a problem hiding this comment.
I'd prefer to avoid words like "should" since we all know what happens in reality. shall or will or needs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @hnyman @s-hamann @drujd @tofurky @neheb @BKPepe @systemcrash @rpavlik
No maintainer, so spamming last 2.x years worth of folks who may be interested.
Description:
Updated configuration was not being applied after config change. This
was due to the means used to do the daemon reloads.
Closes #28298 "Drivers not restarted on config change"
Enable creating PID files for the server, driver, and monitor daemon
processes. This allows to use NUT's built-in facilities for signalling
the daemon's.
For server, when reloading:
For server, when stopping:
stop it.
For monitor, send the reload signal on config change, with fallback to
stopping and starting the daemon.
In the process added linting (ignoring false positives) and fixed whitespace inconsistency.
🧪 Run Testing Details
Only tested with dummy-ups so far. I have a spare UPS on order which should arrive this coming week.
Needs more testing and review.
✅ Formalities