Prefer offsetSet over deprecated attach#161
Merged
sorinsarca merged 2 commits intoopis:php8.5-supportfrom Oct 14, 2025
eliashaeussler:patch-1
Merged
Prefer offsetSet over deprecated attach#161sorinsarca merged 2 commits intoopis:php8.5-supportfrom eliashaeussler:patch-1
offsetSet over deprecated attach#161sorinsarca merged 2 commits intoopis:php8.5-supportfrom
eliashaeussler:patch-1
Conversation
Member
|
Hi @eliashaeussler, I'm using php8.5-support branch to add support for the upcoming version; could you add your contribution there? This way we can have the tests running on php8.5. Thanks! |
`SplObjectStorage::attach()` is deprecated since PHP v8.5; `SplObjectStorage::offsetSet()` should be used instead [1]. [1]: php/php-src#19424
Contributor
Author
|
Hi @sorinsarca, I've adjusted the base branch and rebased my changes :) |
sorinsarca
requested changes
Oct 14, 2025
Contributor
Author
|
Hi @sorinsarca, do you have plans for a PHP 8.5 compatibility release in the near future? :) |
Member
|
Yes, next week |
sorinsarca
added a commit
that referenced
this pull request
Nov 20, 2025
* Added php 8.5 tests * Updated keywords * Prefer `offsetSet` over deprecated `attach` (#161) * Prefer `offsetSet` over deprecated `attach` `SplObjectStorage::attach()` is deprecated since PHP v8.5; `SplObjectStorage::offsetSet()` should be used instead [1]. [1]: php/php-src#19424 * Added test * Updated README --------- Co-authored-by: Elias Häußler <elias@haeussler.dev>
Member
|
@eliashaeussler v4.4.0 was just released |
Contributor
Author
Thank you very much! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SplObjectStorage::attach()is deprecated since PHP v8.5;SplObjectStorage::offsetSet()should be used instead1.Footnotes
https://github.com/php/php-src/pull/19424 ↩