Draft
Conversation
lbillinghamwrk
commented
Jun 11, 2025
Comment on lines
1
to
10
| [tool.black] | ||
|
|
||
| # no custom config yet | ||
|
|
||
| [tool.ruff] | ||
| # lol sob see setup.cfg | ||
| line-length = 730 | ||
| line-length = 120 | ||
|
|
||
| # this should match what is in Dockerfile | ||
| target-version = "py312" | ||
| target-version = "py39" | ||
|
|
Author
There was a problem hiding this comment.
@panneeran
even if we don't want to take the other changes in this PR,
i think its still worth having the pyproject line length be sensible, and aligning python versions between here and the Dockerfile
Line 1 in f83e479
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not totally sure we want to do all of this (or indeed any of it).
blackover the codebase to autoformat itruffis the linter defined in the project file: run ruff's auto fixglobaland apologise for it