Fix NLB IP version selection to respect service ipFamilies
#519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ipFamilyPolicy is PreferDualStack, the getLbListenerBackendSetIpVersion function was incorrectly returning [IPv4, IPv6] based solely on subnet capabilities, ignoring the service's ipFamilies field. This caused issues when: - Service has ipFamilyPolicy: PreferDualStack - Service has ipFamilies: [IPv4] (explicitly IPv4-only) - Subnet supports dual-stack The CCM would create IPv6 listeners even though the service explicitly specifies IPv4-only via ipFamilies. The ipFamilies field is the authoritative specification of what IP families a service uses. The ipFamilyPolicy only influences how ipFamilies gets populated when not explicitly set. This fix ensures the CCM respects ipFamilies by only including IP versions that are both specified in ipFamilies AND supported by the subnet.
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
the
OCA Required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #518
When
ipFamilyPolicyisPreferDualStack, thegetLbListenerBackendSetIpVersionfunction was incorrectly returning[IPv4, IPv6]based solely on subnet capabilities, ignoring the service'sipFamiliesfield.This caused NLB creation to fail with the error:
Root Cause
The bug occurs when:
ipFamilyPolicy: PreferDualStackipFamilies: [IPv4](cluster doesn't support dual-stack, or explicitly set)The old code would create IPv6 listeners (based on subnet capabilities) but only IPv4 backend sets (based on
ipFamilies), causing a mismatch.Fix
The
ipFamiliesfield is the authoritative specification of what IP families a service uses. TheipFamilyPolicyonly influences howipFamiliesgets populated when not explicitly set.This fix ensures the CCM respects
ipFamiliesby only including IP versions that are both:ipFamiliesTesting
Changes
pkg/cloudprovider/providers/oci/load_balancer.go: ModifiedPreferDualStackcase to iterate overipFamiliesand only include IP versions supported by subnetpkg/cloudprovider/providers/oci/load_balancer_test.go: Updated test expectations forPreferDualStackwithipFamilies: [IPv4]