Conversation
meomeocoj
requested review from
ducphamle2,
lehieuhust and
tubackkhoa
and removed request for
ducphamle2
ducphamle2
reviewed
Feb 1, 2024
| } | ||
|
|
||
| for res in unbond_responses.into_iter() { | ||
| response = response.add_attributes(res.clone().attributes); |
Collaborator
There was a problem hiding this comment.
Do we need to add_messages here as well for the _unbond messages?
| ), | ||
| ExecuteMsg::UnbondLock { | ||
| staking_token, | ||
| lock_id, |
Collaborator
There was a problem hiding this comment.
For simplicity I think we can re-use the ExecuteMsg::Unbond by locking new amounts then unbonding old locks all in the same tx
Collaborator
There was a problem hiding this comment.
It is similar to MsgDelegate, where we delegate new tokens while withdrawing all rewards
| amount, | ||
| unlock_time, | ||
| }, | ||
| )?; |
Collaborator
There was a problem hiding this comment.
we can refactor the unbond_lock logic so we can call it in here
tubackkhoa
previously approved these changes
Feb 5, 2024
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this pr do?
LOCK_INFOwhich is multiple array of lock assetlock.unlock_time < env.block.time