Open
Conversation
Update to get all tests working across JDK Versions
Update from origin project
min and max will match the type that are passed (numeric, date, etc.) sum only applies to certain types, but could of course be a sum of integers or decimals, which makes maintaining a matching type a requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This feature intends to generalize the creation of common
FunctionExpressionimplementations within dialects. It introduces aGeneralFunctionExpressionclass for functions that simply need a name and one value, which could be used by any dialects to quickly add functions, particularly aggregates.As such, this pull request also includes the average() function as an addition to the
BaseSQLDialectTesting
Unit tests were added for the base aggregate functions, however, some adjustment was required to make it work generically for all databases as the types returned by the databases for an aggregate are not all the same. Some returned a Long vs a Double for the average() function for example.