Composer Module by gund · Pull Request #2 · orchestratora/rfcs

gund · 2019-03-07T20:17:40Z

RFC text

gund · 2019-03-08T00:22:33Z

Main text was drafted, now it would be nice to have some feedback.

/cc @RyuuGan @baruchvlz

baruchvlz

Looks good, just a few pointers.

baruchvlz · 2019-03-08T15:39:32Z

accepted/0000-composer-module.md

+### `ComposerPreviewComponent`
+
+- Selector: `orc-composer-preview`
+- It will render current json configuration via `orc-orchestrator`


We could use something like hightlight.js to display the JSON

I think it's a good idea, it will be also useful for editing functions when configuring components.

For that matter I think monaco editor will be more suitable, it's what vscode is built on.

This feature will allow to provide autocomplete in functions when writing them

baruchvlz · 2019-03-08T15:40:02Z

accepted/0000-composer-module.md

+## Unresolved Questions and Bikeshedding
+
+- We need to agree how json configuration will be exposed to user. It can be done via output that is triggered when user clicks on `Generate` button or configuration is emitted every time it's changed.
+  This can also be configurable via DI token.


I think we should just display the JSON format and update it on every change.

Yeap, as I wrote we can have an additional component for this purpose.

We don't need an additional component. We can use this in the ComposerPreviewComponent

Actually you are right, we can use both errors and json components in ComposerPreviewComponent, because it is connected with preview.

baruchvlz · 2019-03-08T15:40:32Z

accepted/0000-composer-module.md

+- It should render `RenderItemComponent` inside with `ComposerDroppableComponent` in appropriate places
+- When configuration is updated it should rearrange position of `ComposerDroppableComponent`
+
+### `ComposerPreviewComponent`


Component should have a download button and a copy button so the user can do either action faster.

Aggreed with duplicate button.

RyuuGan

Everything looks good, but I would add some changes

RyuuGan · 2019-03-09T09:25:23Z

accepted/0000-composer-module.md

+
+- `<orc-composer-components>` - will render list of all available components ready for dragging
+- `<orc-composer-canvas>` - will render area for dropping components and configure them
+- `<orc-composer-preview>` - will render currently configured components in live preview


Also I would add 2 more components:

<orc-composer-errors> - will render list of errors that were while rendering

<orc-composer-json> - will render result json, aslo it should be possible to edit the whole config via this json. So when user clicks to download button, we can show this result and copy everything to clipboard.

Both of them can be part of <orc-composer-preview> but named differently and used internally in it.

RyuuGan · 2019-03-09T09:25:28Z

accepted/0000-composer-module.md

+
+Communication between components may happen via inputs/outputs as well as via parent `ComposerComponent`.
+
+Any errors during live preview of configuration must be rendered in toast.


As I wrote before errors can be also rendered to <orc-composer-errors>, so user will know all the errors that happened while renderening. Toast will finally disapper so it is not that reliable.

RyuuGan · 2019-03-09T09:28:49Z

accepted/0000-composer-module.md

+- It should render `RenderItemComponent` inside with `ComposerDroppableComponent` in appropriate places
+- When configuration is updated it should rearrange position of `ComposerDroppableComponent`
+
+### `ComposerPreviewComponent`


Aggreed with duplicate button.

RyuuGan · 2019-03-09T09:30:03Z

accepted/0000-composer-module.md

+## Unresolved Questions and Bikeshedding
+
+- We need to agree how json configuration will be exposed to user. It can be done via output that is triggered when user clicks on `Generate` button or configuration is emitted every time it's changed.
+  This can also be configurable via DI token.


Yeap, as I wrote we can have an additional component for this purpose.

gund · 2019-03-10T18:22:24Z

I've updated RFC with received feedback

baruchvlz

LGTM

RyuuGan

Added fix for small typo. Also added changes that will add Component to all components, otherwise it is a little bit different: some components are named with Component in the end, other not.

Anything else is fine.

accepted/0000-composer-module.md

Co-Authored-By: gund <malkevich.alex@gmail.com>

gund · 2019-03-11T06:20:12Z

Thanks @RyuuGan - I've applied your fixes

RyuuGan

LGTM

re orchestratora/rfcs#2

Co-authored-by: Valery Aligorsky <stdammit@gmail.com> re orchestratora/rfcs#2

Co-Authored-By: Valery Aligorsky <stdammit@gmail.com> re orchestratora/rfcs#2

Co-Authored-By: RyuuGan <stdammit@gmail.com> re orchestratora/rfcs#2

re orchestratora/rfcs#2 Co-Authored-By: RyuuGan <stdammit@gmail.com>

re orchestratora/rfcs#2

So they can be extended via DI from third-party modules re orchestratora/rfcs#2

re orchestratora/rfcs#2

re orchestratora/rfcs#2 Co-Authored-By: RyuuGan <stdammit@gmail.com>

re orchestratora/rfcs#2

So they can be extended via DI from third-party modules re orchestratora/rfcs#2

feat(composer): create initial RFC

7a827bf

gund added the enhancement New feature or request label Mar 7, 2019

fix(composer): add main details to RFC

d9fa84b

baruchvlz reviewed Mar 8, 2019

View reviewed changes

RyuuGan reviewed Mar 9, 2019

View reviewed changes

fix(composer): update RFC with feedback

bd02e96

gund requested review from RyuuGan and baruchvlz March 10, 2019 18:22

baruchvlz approved these changes Mar 10, 2019

View reviewed changes

RyuuGan reviewed Mar 10, 2019

View reviewed changes

fix(composer): apply suggestions from code review

7380e1d

Co-Authored-By: gund <malkevich.alex@gmail.com>

RyuuGan approved these changes Mar 11, 2019

View reviewed changes

gund added a commit to orchestratora/orchestrator that referenced this pull request Mar 15, 2019

feat(composer): add library skeleton

b2f98de

re orchestratora/rfcs#2

gund mentioned this pull request Mar 15, 2019

[Feat] Composer module orchestratora/orchestrator#36

Draft

gund added a commit to orchestratora/orchestrator that referenced this pull request Jun 15, 2019

feat(composer): implement basic drag'n'drop in canvas component

e118002

Co-authored-by: Valery Aligorsky <stdammit@gmail.com> re orchestratora/rfcs#2

gund added a commit to orchestratora/orchestrator that referenced this pull request Jun 15, 2019

feat(composer): implement basic drag'n'drop in canvas component

19aedc1

Co-Authored-By: Valery Aligorsky <stdammit@gmail.com> re orchestratora/rfcs#2

gund added a commit to orchestratora/orchestrator that referenced this pull request Jun 15, 2019

feat(composer): implement basic drag'n'drop in canvas component

fc51b6f

Co-Authored-By: RyuuGan <stdammit@gmail.com> re orchestratora/rfcs#2

gund added a commit to orchestratora/orchestrator that referenced this pull request Jun 15, 2019

feat(composer): implement basic drag'n'drop in canvas component

4c09d4f

re orchestratora/rfcs#2 Co-Authored-By: RyuuGan <stdammit@gmail.com>

gund added a commit to orchestratora/orchestrator that referenced this pull request Jun 16, 2019

refactor(composer): use RenderComponent API in droppable component

617ca67

re orchestratora/rfcs#2

gund added a commit to orchestratora/orchestrator that referenced this pull request Jun 16, 2019

fix(composer): update components with new config

64d71aa

re orchestratora/rfcs#2

gund added a commit to orchestratora/orchestrator that referenced this pull request Aug 6, 2019

refactor(composer): extract decortator configurations components into DI

076ccf2

So they can be extended via DI from third-party modules re orchestratora/rfcs#2

gund added a commit to orchestratora/orchestrator that referenced this pull request Jan 15, 2022

feat(composer): add library skeleton

5876771

re orchestratora/rfcs#2

gund added a commit to orchestratora/orchestrator that referenced this pull request Jan 15, 2022

feat(composer): implement basic drag'n'drop in canvas component

fa11f61

re orchestratora/rfcs#2 Co-Authored-By: RyuuGan <stdammit@gmail.com>

gund added a commit to orchestratora/orchestrator that referenced this pull request Jan 15, 2022

refactor(composer): use RenderComponent API in droppable component

78bfe38

re orchestratora/rfcs#2

gund added a commit to orchestratora/orchestrator that referenced this pull request Jan 15, 2022

fix(composer): update components with new config

28d954d

re orchestratora/rfcs#2

gund added a commit to orchestratora/orchestrator that referenced this pull request Jan 15, 2022

refactor(composer): extract decortator configurations components into DI

2dddd92

So they can be extended via DI from third-party modules re orchestratora/rfcs#2


		Communication between components may happen via inputs/outputs as well as via parent `ComposerComponent`.

		Any errors during live preview of configuration must be rendered in toast.

Conversation

gund commented Mar 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gund commented Mar 8, 2019

Uh oh!

baruchvlz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RyuuGan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gund commented Mar 10, 2019

Uh oh!

baruchvlz left a comment

Choose a reason for hiding this comment

Uh oh!

RyuuGan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gund commented Mar 11, 2019

Uh oh!

RyuuGan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gund commented Mar 7, 2019 •

edited

Loading