Adding support Mariadb events, such as GTID and annotate rows event(sql)

[wingerx]

1. Change EventType to use eventNumber not ordinal().
   ANNOTATE_ROWS(160), MARIADB_GTID(162) MARIADB_GTID_LIST(163)
2. Add MariaDB event data implements, not only types.
3. Now MariaDB can support query(sql) event and GTID events

@osheroff pls check this PR, ths.

[osheroff]

generally speaking I'd prefer inheritance over a bunch of if statements. Can we try to make MariaDBBinaryLogConnector class that inherits from the base class and changes functionality that way?

I'd also like to see quite a few more tests around mariaDB functionality, if possible -- especially ensuring that we test all the various deserializers.

[wingerx]

generally speaking I'd prefer inheritance over a bunch of if statements. Can we try to make MariaDBBinaryLogConnector class that inherits from the base class and changes functionality that way?

I'd also like to see quite a few more tests around mariaDB functionality, if possible -- especially ensuring that we test all the various deserializers.

ok, i will try to refact.

[osheroff]

please leave the import style alone. everyone's editor has an opinion about how imports should be done and they're always changing back and forth. I personally do not care even a little bit but I'm tired of it changing all the time.

[osheroff]

rename: buildGtidSet

[osheroff]

rename: setupGtidSet

[osheroff]

rename: ensureGtidEventDataDeserializer

[osheroff]

if you look at the implementation of getQuerySql, you'll see that this is false sharing -- in the case of MariaDB's QUERY event it bounces right back to the mysql-compatible getQuerySql.

Therefore -- keep the implementation of the QUERY case the same, just make a different impl for maria.

[osheroff]

does maria-db not support the gtid_purged variable?

[wingerx]

yeah, u can find this in https://mariadb.com/kb/en/system-variable-differences-between-mariadb-100-and-mysql-56/

[osheroff]

i don't think we need all the isUseSendAnnotate stuff. It's not going to hurt anything to have an unsed data deserializer in there.

[osheroff]

needs some documentation about setting maria-db specific flags and such

[gunnarmorling]

Hey @jpechane, @Naros, check this one out, it will probably be relevant for the MariaDB exploration within Debezium.

Great effort, @wingerx!

[jpechane]

@wingerx Great effort, thanks! Does the code incorporate old PRs?

• Add mariadb event types shyiko/mysql-binlog-connector-java#280
• Support MariaDB GTID shyiko/mysql-binlog-connector-java#50
• merge mariadb support from wenerme  shyiko/mysql-binlog-connector-java#135

Thanks

[wingerx]

No, i think they are similar only in Mariadb

[xiaoyu19950911]

There should be some different implementations of Mariadb,look at https://github.com/shyiko/mysql-binlog-connector-java/pull/135/commits/36fca51464ccb8eb900b2addc23ac7e6c1c623ff

[scottmf]

hi, I haven't seen any activity on this in a while. Is this is a dead PR or is there a chance of it moving forward? I, like many others, am eagerly awaiting GTID support for mariadb :)

[arman1371]

Hi
Thanks for your effort.
Is there any activity here? Can we use this development branch and hope this will be merged soon?

[ivapiv]

Hi @osheroff, could you maybe share any updates regarding the status in this PR? If you could let us know what is missing in order the changes to make it on master, would be happy to contribute and help to move forward with it.

[osheroff]

trying to get this going here #79