Open
Conversation
…ability by simplifying the implementation. Also improved the performance by utilizing list.extend method instead of `+` concatenation. Extension modifies a list in place, instead of creating a new list by `+`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added test coverage for batched_parmap function and improved its readability by simplifying the implementation. Also improved the performance by utilizing list.extend method instead of
+concatenation. Extension modifies a list in place, instead of creating a new list by+Motivation and Context
Currently batched_parmap has unnecessary cyclomatic complexity, because it has to check for trailing chunks of batches in case when size of
argsis not divisible bybatch_size. Even though the check is implemented, this case is not covered by tests.Also, memory consumption of this function can be reduced by replacing list concatenation with list extension.
Fixes #104
How has this been tested?
I provided a unit test and ran all other tests.
Types of changes
Checklist: