Open
Conversation
helabenkhalfallah
requested review from
aboungnaseng-ovhcloud and
anooparveti
github-actions
bot
added
dependencies
Contributor
|
| Name | Status | Previous | Current |
|---|---|---|---|
@sinclair/typebox |
0.34.47 | 0.34.48 | |
axios |
1.13.2 | 1.13.4 | |
semver |
7.7.2 | 7.7.4 |
Contributor
Author
Validation TestsCase of Nx from node-modulesBuildOptions are correctly passed to nx: Usage of node modules: LintTestsCase of Nx from bin (global install)(waiting for developers feedback) Case of Nx with old version (fallback to Turbo)Before: After downgrade: Result: Starting Turbo |
ref: #MANAGER-20638 Signed-off-by: Héla Ben Khalfallah <helabenkhalfallah@hotmail.fr>
ref: #MANAGER-20638 Signed-off-by: Héla Ben Khalfallah <helabenkhalfallah@hotmail.fr>
ref: #MANAGER-20638 Signed-off-by: Héla Ben Khalfallah <helabenkhalfallah@hotmail.fr>
helabenkhalfallah
force-pushed
the
feat/MANAGER-20638-v2
branch
from
5702a98 to
b65e149
Compare
tibs245
reviewed
Feb 9, 2026
| * @param {string} workspaceRoot | ||
| * @returns {Promise<string|null>} | ||
| */ | ||
| async function readLocalNxPackageVersion(workspaceRoot) { |
Contributor
There was a problem hiding this comment.
Just by curiosity / suggestion : Why don't use Effect here with Some or Result ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some Linux (Ubuntu) developers can’t reliably install or run Nx via local Node/Yarn installs (e.g.
yarn global add nxhanging or failing due to native permissions / lack of root privileges). Support validated a workaround: install Nx via APT (system binary/usr/bin/nx) + ensure an executable TMP directory.Today,
manager-pm --runner nxassumes Nx is available in the usual local Node environment. This leads to inconsistent developer experience on Linux and blocks adoption.Ticket Reference: #MANAGER-20638
Additional Information
What this PR does
✅ Makes Nx runner resolution robust
When passing
--runner nx(e.g.yarn lint --runner nx,yarn build --runner nx),manager-pmnow resolves Nx in a deterministic order:/usr/bin/nxfrom APT or PATH lookup) if version ≥ 22.3.3This guarantees:
✅ Path-aware Nx detection in task execution
Because Nx can now resolve to an absolute path (e.g.
/usr/bin/nx), runner checks are updated from:runner === 'nx'to:
isNxRunner(runner)(detects"nx"or a path ending withnx,nx.cmd,nx.exe)This prevents incorrect branching and ensures Nx-specific argument mapping still works.
✅ No reliance on env vars
Resolution is performed via filesystem + command invocation (
--version, PATH resolution) rather than env-based heuristics, to stay compatible with our custom CI/CD environment.Impact / Risk
--runner nxValidation Tests
#22112 (comment)