feat(pci-instances): add fip gateway DTO#22121
Open
Rom123Soleil wants to merge 1 commit intofix/handle-instance-creation-multi-fixesfrom
Open
feat(pci-instances): add fip gateway DTO#22121Rom123Soleil wants to merge 1 commit intofix/handle-instance-creation-multi-fixesfrom
Rom123Soleil wants to merge 1 commit intofix/handle-instance-creation-multi-fixesfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for a Floating IP (FIP) gateway data transfer object (DTO) to the PCI instances module, enabling the system to track and utilize gateway information beyond just the gateway IP address.
Changes:
- Introduced a new
TNetworkGatewaytype to represent gateway objects with external gateway status, ID, and name - Added
hasGatewayfield to private network data alongside the existinghasGatewayIpfield - Updated gateway availability logic to check for gateway object presence instead of just gateway IP
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/manager/apps/pci-instances/src/domain/entities/configuration.ts | Defines the new TNetworkGateway type and adds optional gateway field to TSubnet |
| packages/manager/apps/pci-instances/src/adapters/tanstack/configuration/right/dto.type.ts | Adds TNetworkGatewayOutDTO type and optional gateway field to TSubnetDTO |
| packages/manager/apps/pci-instances/src/adapters/tanstack/configuration/right/mapper.ts | Maps the gateway field from DTO to entity |
| packages/manager/apps/pci-instances/src/pages/instances/create/view-models/networksViewModel.ts | Adds hasGateway to private network data and refactors gateway availability check to use gateway object instead of gateway IP |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aTurmo
approved these changes
Feb 6, 2026
ZyaCon
approved these changes
Feb 6, 2026
lolottetheclash
changed the base branch from
master
to
fix/handle-instance-creation-multi-fixes
lolottetheclash
requested review from
ErikssonJoakim,
Taelar,
Tsiorifamonjena,
fredericvilcot and
lolottetheclash
lolottetheclash
approved these changes
Feb 6, 2026
Contributor
lolottetheclash
left a comment
lolottetheclash
left a comment
There was a problem hiding this comment.
well done @Rom123Soleil 🥳
Tsiorifamonjena
force-pushed
the
fix/pci-instances-fip-creation
branch
from
f3dddf7 to
3d447cd
Compare
Signed-off-by: Romain Dupont <romain@familledupont.org> Co-authored-by: tsiorifamonjena <tsiorifamonjena.tianjanahary.ext@corp.ovh.com>
Tsiorifamonjena
force-pushed
the
fix/pci-instances-fip-creation
branch
from
3d447cd to
336bc19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.