Skip to content

Conversation

@goulart-paul
Copy link
Member

No description provided.

@goulart-paul goulart-paul merged commit f957a06 into main Jun 11, 2025
1 check passed
This was referenced Jun 11, 2025
@matbesancon
Copy link
Contributor

Shouldn't the main CMakeFile also define CLARABEL_RUST_FEATURES before passing it to the rust_wrapper build? At the moment it gets ignored, which is confusing

@goulart-paul
Copy link
Member Author

Shouldn't the main CMakeFile also define CLARABEL_RUST_FEATURES before passing it to the rust_wrapper build? At the moment it gets ignored, which is confusing

Fair point. I made a minor cleanup in #69, putting it into the main CMakeLists.txt. I also renamed it CLARABEL_CARGO_FEATURES to emphasise that it's the list of features to be passed directly to cargo.

The other features (i.e. CLARABEL_FEATURE_XXX) aren't actually necessary anymore since all are just appending the appropriate cargo options to CLARABEL_CARGO_FEATURES, but I kept them in for backward compatibility. Maybe they are also a bit more convenient when using ccmake or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants