add MSRV check to CI #938
Open
add MSRV check to CI #938
+28
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the toolchain file and added proper MSRV declarations. Libraries should not pin toolchains - this forces a specific Rust version on all contributors and downstream consumers, preventing them from using newer toolchains. Instead, libraries should declare their MSRV in Cargo.toml and verify it in CI.
Changes:
typifycrate, since this is what downstream consumers are exposed to)derivefeature to serde dependencies in typify-test (this is a real dependency that was implicitly satisfied through dev-deps, but cargo hack with --no-dev-deps exposes the missing feature)