fix: Ignored target defined via cargo config file#654
Open
Stranger6667 wants to merge 1 commit intooxidize-rb:mainfrom
Open
fix: Ignored target defined via cargo config file#654Stranger6667 wants to merge 1 commit intooxidize-rb:mainfrom
target defined via cargo config file#654Stranger6667 wants to merge 1 commit intooxidize-rb:mainfrom
Conversation
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
seuros
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #568
Besides these tests, I've checked it with the
rust_reverseexample by addingexamples/rust_reverse/ext/rust_reverse/.cargo/config.toml:and building it.
I am very sorry for parsing toml with regexes :( Let me know if it would be better to pull the proper parser as a dependency (as per my understanding, no external dependencies is one of the goals?) - I also saw that the package name is parsed with a regex already (as a fallback). As of now,
cargo configis unstable :(P.S. I think that if a benchmark is defined first in
Cargo.toml, then the name inference would take that instead of the package name