Draft
Conversation
Implements #674 - Add fl_able() to StableApiDefinition trait - Implement for Ruby 2.7, 3.0, 3.1, 3.2, 3.3, 3.4, 4.0 - Add C fallback in compiled.c - Add public FL_ABLE macro wrapper - Add parity tests This is the foundation method for flag operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
fl_able()method to the Stable API for checking if an object can have flags set. This is Batch 1 of the stable API implementation plan and provides the foundation for flag operations (Batch 2: FL_TEST, FL_SET, FL_UNSET).The
fl_able()method returnsfalsefor immediate values (nil, true, false, Fixnum, Symbol, Flonum) which don't have flag storage in the Ruby object header, andtruefor heap objects that can have flags.Changes
fl_able()method toStableApiDefinitiontrait!special_const_p()from the Ruby C APIcompiled.cand Rust wrapper incompiled.rsusingRB_FL_ABLEFL_ABLEmacro wrapper inmacros.rswith comprehensive documentationstable_api_test.rscovering all immediate types and heap objectsTesting
All tests pass successfully:
Related Issues
Foundation for:
Checklist