feat(stable-api): add RB_OBJ_WRITE and RB_OBJ_WRITTEN for GC write barrier#678
Draft
feat(stable-api): add RB_OBJ_WRITE and RB_OBJ_WRITTEN for GC write barrier#678
Conversation
5 tasks
9b07443 to
fdd1294
Compare
|
This looks good to me, is there anything I can do to help move this forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch 3 of the stable API implementation plan - Adds GC write barrier methods
RB_OBJ_WRITEandRB_OBJ_WRITTENto the Stable API.These methods are critical for maintaining GC correctness when storing VALUE references from one heap object to another. This is a prerequisite for Batch 6 (RARRAY_ASET).
Changes
rb_obj_write()andrb_obj_written()methods toStableApiDefinitiontraitrb_gc_writebarrier()andrb_gc_writebarrier_unprotect()internallycompiled.cand Rust wrapper incompiled.rsRB_OBJ_WRITEandRB_OBJ_WRITTENmacro wrappers inmacros.rsstable_api_test.rsTesting
All tests pass successfully ✅
Related Issues
StableApiDefinitionGC methods #447Checklist