Feature: support for skipping requests to some hosts#12
Open
alexsorokoletov wants to merge 1 commit intooyyd:masterfrom
Open
Feature: support for skipping requests to some hosts#12alexsorokoletov wants to merge 1 commit intooyyd:masterfrom
alexsorokoletov wants to merge 1 commit intooyyd:masterfrom
Conversation
Author
|
@oyyd would be great if you can take a look at this PR once you have a chance. Thank you! |
alexsorokoletov
force-pushed
the
skip-local
branch
from
b3127b4 to
9143b82
Compare
alexsorokoletov
changed the title
alexsorokoletov
force-pushed
the
skip-local
branch
from
9143b82 to
160c2e3
Compare
allows skipping local requests or any other requests by hostname
alexsorokoletov
force-pushed
the
skip-local
branch
from
160c2e3 to
96222ee
Compare
alexsorokoletov
changed the title
oyyd
reviewed
Nov 17, 2019
| target: { host: ph.hostname, port: ph.port }, | ||
| }); | ||
| } else { | ||
| logger.info('skipping this request because it is local'); |
Owner
There was a problem hiding this comment.
The skip has beed listed at the start so that I prefer we don't log again here.
Owner
|
Great work! LGTM and leave a comment. The new option |
Author
|
Good points, @Ooyd! I’ll address them 🤝 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I noticed all of the requests go directly to the proxy.
It would be great to have an option to skip requests to some hosts (usually these are local requests that do not need a proxy).
I appreciate any feedback on code/feature.
Thank you for this tool!