Draft
Conversation
Add ZSTD format handler using Compression Streams
Use WASM-based ZSTD decoding and add coverage test
Owner
|
Hm, outputting some nondescript binary file doesn't really make much sense here. If you had a ZSTD compressed DOCX and wanted to turn that into a PDF, this wouldn't really let you do that. I'd almost like to treat this as a "meta" handler, in the sense that it doesn't really fit in the regular conversion graph at all. There's underlying data of its own type that we can probably handle with something else, but not before it's passed through this. My thoughts on how this should be implemented are very divided, but it certainly seems like it needs more work and consideration beyond simply decompressing to a binary blob. |
|
are you still working on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added ZSTD support via Webassembly.