don't override THREE.InstancedMesh#39
Open
trusktr wants to merge 1 commit intopailhead:masterfrom
lume:dont-override-THREE.InstancedMesh
Open
don't override THREE.InstancedMesh#39trusktr wants to merge 1 commit intopailhead:masterfrom lume:dont-override-THREE.InstancedMesh
trusktr wants to merge 1 commit intopailhead:masterfrom
lume:dont-override-THREE.InstancedMesh
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some issue with newer three.js, where three.js manages to overwrite
THREE.InstancedMeshwith its own one (didn't happen before I updated from r108 to r121).It is probably better to rely on the return value of three-instanced-mesh, and for it not to override three.js API (I presume at the time this lib was made there was no
THREE.InstancedMesh.