Skip to content

Add support for multiple values for a config param (e.g. 'setParameter') #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dobladez wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add support for multiple values for a config param (e.g. 'setParameter') #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/pallet/crate/mongodb.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,17 @@
(defn to-config-file
"Generate the .config file contents out of a map of config option, value"
[config]
(apply str
(map (fn [[k v]]
(format "%s=%s\n" (name k) v))
config)))
(letfn [(format-simple-kv [k v]
(format "%s=%s\n" (name k) v))
(format-mutivalue-kvs [k vs]
(map (fn [v] (format-simple-kv k v) ) vs))]
(apply str
(mapcat (fn [[k v]]
(if (vector? v)
(format-mutivalue-kvs k v)
(format-simple-kv k v)))
config))))


(defplan settings
"Build the configuration settings by merging the user supplied ones
Expand Down
22 changes: 22 additions & 0 deletions test/pallet/crate/mongodb_test.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,25 @@
("service" networking restart))))
:test (plan-fn (wait-for-port-listen 30000))}
:phases-meta {:install (execute-and-flag-metadata :install)}))


(deftest config-file

(test/are [mapconfig expected-text]

(= (mongodb/to-config-file mapconfig) expected-text)

{:name "value"}
"name=value\n"

(sorted-map :name "value" :setParameter "logLevel=4")
(str "name=value\n"
"setParameter=logLevel=4\n")


;; Vector values expand to multiple lines of the same configuration key
(sorted-map :name "value" :setParameter ["logLevel=4" "textSearchEnabled=true"])
(str "name=value\n"
"setParameter=logLevel=4\n"
"setParameter=textSearchEnabled=true\n")) )